WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 55102
A user gesture should not be required to open the file chooser dialog if the pop-up blocker is disabled.
https://bugs.webkit.org/show_bug.cgi?id=55102
Summary
A user gesture should not be required to open the file chooser dialog if the ...
Andy Estes
Reported
2011-02-23 16:35:36 PST
This matches Firefox 4's behavior. Users should be able to opt out of our protections if they so choose.
Attachments
patch v1
(7.87 KB, patch)
2011-03-15 09:15 PDT
,
Johnny(Jianning) Ding
adele
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Johnny(Jianning) Ding
Comment 1
2011-03-15 09:15:55 PDT
Created
attachment 85815
[details]
patch v1
Adele Peterson
Comment 2
2011-04-26 15:47:54 PDT
I'm not sure this is a good idea. Even if a user turns off pop-up blocking, then might not expect that script can open the file chooser dialog.
Andy Estes
Comment 3
2011-04-26 15:56:13 PDT
This bug was based on a discussion I had with jnd about improving how we block file dialogs. This probably isn't as important to fix since we landed <
http://trac.webkit.org/changeset/81057
>, as that patch allows apps that rely on opening file choosers via setTimeout() to continue to work without changing the pop-up blocker pref.
Adele Peterson
Comment 4
2011-04-26 15:58:26 PDT
Comment on
attachment 85815
[details]
patch v1 ok, then r-'ing for now. If someone wants to argue for this, I'll reconsider.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug