Bug 55094 - WebCursorInfo needs to match enums in platform/Cursor.h
Summary: WebCursorInfo needs to match enums in platform/Cursor.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Avi Drissman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-23 15:35 PST by Avi Drissman
Modified: 2011-03-01 07:11 PST (History)
5 users (show)

See Also:


Attachments
Patch for missing values (991 bytes, patch)
2011-02-23 16:07 PST, Avi Drissman
avi: review-
avi: commit-queue-
Details | Formatted Diff | Diff
Updated version; adds checks to keep three enum lists from getting out of sync again. (6.58 KB, patch)
2011-02-23 16:59 PST, Avi Drissman
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Try again. Clarified ChangeLog, though no code change. (6.56 KB, patch)
2011-02-28 07:25 PST, Avi Drissman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Avi Drissman 2011-02-23 15:35:32 PST
In WebKit/chromium/src/WebCursorInfo.cpp:

WebCursorInfo::WebCursorInfo(const Cursor& cursor)
{
    type = static_cast<Type>(cursor.impl().type());

yet WebCursorInfo::Type has two fewer items in the enum than Cursor::Type.

This needs to be fixed.
Comment 1 Avi Drissman 2011-02-23 16:07:06 PST
Created attachment 83571 [details]
Patch for missing values
Comment 2 James Robinson 2011-02-23 16:08:04 PST
Comment on attachment 83571 [details]
Patch for missing values

R=me
Comment 3 WebKit Review Bot 2011-02-23 16:25:22 PST
Attachment 83571 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7986260
Comment 4 Avi Drissman 2011-02-23 16:59:16 PST
Created attachment 83581 [details]
Updated version; adds checks to keep three enum lists from getting out of sync again.
Comment 5 WebKit Review Bot 2011-02-23 17:08:50 PST
Attachment 83581 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7981236
Comment 6 Eric Seidel (no email) 2011-02-24 02:39:31 PST
Comment on attachment 83581 [details]
Updated version; adds checks to keep three enum lists from getting out of sync again.

View in context: https://bugs.webkit.org/attachment.cgi?id=83581&action=review

OK.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This shoudl be replaced by either a list of tests or explainaion why testing is impossible.
Comment 7 Eric Seidel (no email) 2011-02-24 02:39:49 PST
Comment on attachment 83581 [details]
Updated version; adds checks to keep three enum lists from getting out of sync again.

cq would fail,a nd cr-linux is borked anyway.
Comment 8 Avi Drissman 2011-02-24 04:36:45 PST
This is temporarily blocked by some issues on the Chromium side; will fix today.

There is no functional code being added, just enums. Tests are being added: a list of compile asserts that everything matches up so that this won't happen again.
Comment 9 Avi Drissman 2011-02-28 07:25:07 PST
Created attachment 84056 [details]
Try again. Clarified ChangeLog, though no code change.

The dependency on the Chromium side was fixed; this should pass all trybots.
Comment 10 James Robinson 2011-02-28 15:15:14 PST
Comment on attachment 84056 [details]
Try again. Clarified ChangeLog, though no code change.

Looks good.
Comment 11 WebKit Commit Bot 2011-02-28 16:52:00 PST
Comment on attachment 84056 [details]
Try again. Clarified ChangeLog, though no code change.

Clearing flags on attachment: 84056

Committed r79942: <http://trac.webkit.org/changeset/79942>
Comment 12 WebKit Commit Bot 2011-02-28 16:52:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 13 WebKit Review Bot 2011-02-28 18:07:42 PST
http://trac.webkit.org/changeset/79942 might have broken Qt Linux Release
The following tests are not passing:
fast/events/tabindex-focus-blur-all.html
fast/frames/iframe-plugin-load-remove-document-crash.html
fast/frames/sandboxed-iframe-attribute-parsing.html
fast/layers/clip-rects-transformed.html
fast/replaced/object-with-non-empty-classid-triggers-fallback.html
plugins/createScriptableObject-before-start.html
plugins/destroy-on-setwindow.html
plugins/destroy-plugin-from-callback.html
plugins/destroy-stream-twice.html
plugins/document-open.html
plugins/evaluate-js-after-removing-plugin-element.html
plugins/get-file-url.html
plugins/get-url-that-the-resource-load-delegate-will-disallow.html
plugins/get-url-with-javascript-destroying-plugin.html
plugins/geturl-replace-query.html
plugins/geturlnotify-during-document-teardown.html
plugins/instance-available-before-stylesheets-loaded-object.html
plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html
plugins/js-from-destroy.html
Comment 14 Avi Drissman 2011-03-01 07:11:10 PST
(In reply to comment #13)
> http://trac.webkit.org/changeset/79942 might have broken Qt Linux Release
> The following tests are not passing:

Huh? All the patch did was add enums to platform/chromium.