Bug 55087 - webkitpy.layout_tests.layout_package.manager_worker_broker_unittest.FunctionTests.test_get__processes sometimes fails on Windows
Summary: webkitpy.layout_tests.layout_package.manager_worker_broker_unittest.FunctionT...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Dirk Pranke
URL: http://build.webkit.org/builders/Wind...
Keywords: InRadar, PlatformOnly
Depends on:
Reported: 2011-02-23 14:50 PST by Adam Roben (:aroben)
Modified: 2012-05-14 12:13 PDT (History)
8 users (show)

See Also:

Patch (1.64 KB, patch)
2011-02-28 16:58 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-23 14:50:19 PST
webkitpy.layout_tests.layout_package.manager_worker_broker_unittest.FunctionTests.test_get__processes is sometimes failing on Windows. For example:

Did not fail: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9673
Did fail: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9679

So far I've only seen it fail on apple-windows-5, which is running Python 2.6.5. I believe apple-windows-6 is running Python 2.5.x.
Comment 1 Dirk Pranke 2011-02-23 17:40:44 PST
Hm. That test is showing python-level failures in the "multiprocessing" module, which is only available under Python 2.6. So that test won't run (or fail) under 2.5.

We'll have to watch it to see how flaky it is ...
Comment 3 Adam Roben (:aroben) 2011-02-24 07:33:29 PST
More failures:


So it failed 4 times from build 9662 to build 9691, inclusive. That's once every 7 builds or so.
Comment 4 Adam Roben (:aroben) 2011-02-27 10:18:00 PST
Comment 5 Adam Roben (:aroben) 2011-02-28 08:07:19 PST
We've been seeing cases where lots of python processes are left around on the bots. I wonder if this bug is the/a cause of that?
Comment 6 Dirk Pranke 2011-02-28 13:08:36 PST
(In reply to comment #5)
> We've been seeing cases where lots of python processes are left around on the bots. I wonder if this bug is the/a cause of that?

It's quite possible. When I briefly had the multiprocessing module enabled for new-run-webkit-tests, we also seemed to see a bunch of processes lying around. 

I think I'll disable this test for now until I can do some more testing on Windows and see if there are bugs I can reproduce/triage/fix.
Comment 7 Dirk Pranke 2011-02-28 16:25:45 PST
Assigning to myself and skipping for now until I can triage it further.
Comment 8 Dirk Pranke 2011-02-28 16:58:49 PST
Created attachment 84152 [details]
Comment 9 Dirk Pranke 2011-02-28 18:34:20 PST
I don't like skipping tests ... anyone have any ideas before I disable it?
Comment 10 Adam Roben (:aroben) 2011-03-01 05:55:49 PST
Skipped the test on Windows to get the bots green

Committed r79993: <http://trac.webkit.org/changeset/79993>
Comment 11 WebKit Review Bot 2011-03-01 08:39:16 PST
http://trac.webkit.org/changeset/79993 might have broken GTK Linux 32-bit Debug
Comment 12 Dirk Pranke 2011-03-02 18:17:54 PST
clearing ownership now that I've disabled the bug, in the off chance that someone else wants to take this.
Comment 13 Eric Seidel (no email) 2011-06-18 13:43:00 PDT
Attachment 84152 [details] was posted by a committer and has review+, assigning to Dirk Pranke for commit.
Comment 14 Dirk Pranke 2011-06-20 12:19:36 PDT
It looks like aroben landed this in r79993. Closing.
Comment 15 Raphael Kubo da Costa (:rakuco) 2012-05-14 11:13:51 PDT
Has this been further investigated? I was looking at eliminating more uses of sys.platform and came across this one.
Comment 16 Dirk Pranke 2012-05-14 12:13:27 PDT
Nope, I haven't had a chance to look into it further, and it's not super-high on my priority list.