RESOLVED FIXED 55074
[Qt][WK2] Build Webkit2 using "-2" option on Qt 
https://bugs.webkit.org/show_bug.cgi?id=55074
Summary [Qt][WK2] Build Webkit2 using "-2" option on Qt
Chang Shu
Reported 2011-02-23 12:53:02 PST
As Qt WebKit2 port is getting more attraction, it's nice to build WebKit2 by default through build-webkit script.
Attachments
fix patch (1.12 KB, patch)
2011-02-23 12:55 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
fix patch 2 (1.86 KB, patch)
2011-04-01 11:46 PDT, Chang Shu 		ossy: review-
DetailsFormatted DiffDiff
fix patch 3: update based on review (1.62 KB, patch)
2011-04-01 14:06 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-02-23 12:55:53 PST
Created attachment 83528 [details] fix patch
Laszlo Gombos
Comment 2 2011-02-23 14:48:06 PST
Comment on attachment 83528 [details] fix patch I think this needs to be qualified so that WebKit2 is only turned on by default for platforms where we intend to support WebKit2. In general, I think it is too early for turning this on by default even for Linux.
Chang Shu
Comment 3 2011-04-01 11:45:00 PDT
Add a shortcut option in command line to build webkit2.
Chang Shu
Comment 4 2011-04-01 11:46:55 PDT
Created attachment 87890 [details] fix patch 2
Chang Shu
Comment 5 2011-04-01 11:48:18 PDT
just too lazy to type the whole qmake thing. :)
Csaba Osztrogonác
Comment 6 2011-04-01 13:57:21 PDT
Comment on attachment 87890 [details] fix patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=87890&action=review The idea is great, but we can make it simpler. Please fix it, and I'll r+ it. > Tools/Scripts/build-webkit:308 > + $noWebKit2 = !isWK2(); > + Remove this line. > Tools/Scripts/build-webkit:359 > + -2 build WebKit2 It affects only the Qt port, "Build WebKit2 (Qt only)" would be better comment > Tools/Scripts/build-webkit:511 > + push @options, "--qmakearg=CONFIG+=webkit2" if !$noWebKit2; push @options, "--qmakearg=CONFIG+=webkit2" if isWK2();
Chang Shu
Comment 7 2011-04-01 14:06:01 PDT
Created attachment 87911 [details] fix patch 3: update based on review
WebKit Commit Bot
Comment 8 2011-04-01 16:39:07 PDT
Comment on attachment 87911 [details] fix patch 3: update based on review Clearing flags on attachment: 87911 Committed r82745: <http://trac.webkit.org/changeset/82745>
WebKit Commit Bot
Comment 9 2011-04-01 16:39:12 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 10 2011-04-01 18:46:13 PDT
Simpler fix was wrong, because @ARGV was copied to @options before isWK2() removed the "-2" from @ARGV and it was passed to qmake. Arghhhh. :-/ I fixed it: http://trac.webkit.org/changeset/82756
Note You need to log in before you can comment on or make changes to this bug.