Bug 55073 - [Chromium] Add WebKitClient::cryptographicallyRandomValues
Summary: [Chromium] Add WebKitClient::cryptographicallyRandomValues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-23 12:47 PST by Adam Barth
Modified: 2011-02-23 14:08 PST (History)
2 users (show)

See Also:

Attachments
Patch (will add ChangeLog before landing) (651 bytes, patch)
2011-02-23 12:47 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2011-02-23 13:44 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2011-02-23 13:50 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-02-23 12:47:07 PST 
We need this to get random values into WTF while inside the sandbox.
Comment 1 Adam Barth 2011-02-23 12:47:49 PST 
Created attachment 83527 [details]
Patch (will add ChangeLog before landing)
Comment 2 WebKit Review Bot 2011-02-23 12:54:18 PST 
Attachment 83527 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7987213
Comment 3 Adam Barth 2011-02-23 13:44:14 PST 
Created attachment 83540 [details]
Patch
Comment 4 Darin Fisher (:fishd, Google) 2011-02-23 13:48:48 PST 
Comment on attachment 83540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83540&action=review

> Source/WebKit/chromium/public/WebKitClient.h:270
> +        volatile char* nullPointer = 0;

high there, please let me introduce you to my friend, WEBKIT_ASSERT_NOT_REACHED()
Comment 5 Adam Barth 2011-02-23 13:50:55 PST 
Created attachment 83542 [details]
Patch
Comment 6 Adam Barth 2011-02-23 14:08:40 PST 
Committed r79487: <http://trac.webkit.org/changeset/79487>