Bug 55065 – Setting shadow host should also attach and set inDocument, just like appending/inserting a child.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dimitri Glazkov (Google)]

Setting shadow host should also attach and set inDocument, just like appending/inserting a child.

[Dimitri Glazkov (Google)]

Created attachment 83507 [details]
Patch

[Darin Adler]

Comment on attachment 83507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83507&action=review

> Source/WebCore/dom/Element.cpp:1143
> +    if (inDocument())
> +        newRoot->insertedIntoDocument();

Is there a case where newRoot was already in a document?

[Dimitri Glazkov (Google)]

(In reply to comment #2)
> (From update of attachment 83507 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83507&action=review
> 
> > Source/WebCore/dom/Element.cpp:1143
> > +    if (inDocument())
> > +        newRoot->insertedIntoDocument();
> 
> Is there a case where newRoot was already in a document?

Not currently, but we will have to defend against this once script is allowed to set shadowHost. I have a FIXME at the top of the method to not forget.

[WebKit Commit Bot]

Comment on attachment 83507 [details]
Patch

Clearing flags on attachment: 83507

Committed r79468: <http://trac.webkit.org/changeset/79468>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.