Bug 55059 - WKBundleNavigationAction.h should be exposed as a public header
Summary: WKBundleNavigationAction.h should be exposed as a public header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.6
: P2 Normal
Assignee: Mike Thole
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-23 10:44 PST by Mike Thole
Modified: 2011-02-23 11:43 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (2.25 KB, patch)
2011-02-23 10:45 PST, Mike Thole 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Thole 2011-02-23 10:44:05 PST 
WKBundleNavigationAction.h should be exposed as a public header, so that it can be used in the injected bundle.
Comment 1 Mike Thole 2011-02-23 10:45:47 PST 
Created attachment 83502 [details]
Proposed patch
Comment 2 Darin Adler 2011-02-23 10:47:34 PST 
Comment on attachment 83502 [details]
Proposed patch

Correct to change this from project. But I believe it should be private, not public, because WebKit2 is Mac OS X SPI, not API, at this time.
Comment 3 Mike Thole 2011-02-23 10:50:44 PST 
Committed revision 79459.
Comment 4 Mike Thole 2011-02-23 10:54:09 PST 
I left it as 'Public', which matches equivalent headers (e.g. WKBundleNodeHandle.h, WKBundlePage.h) in WK2.  I think the system-level API vs. SPI issue is handled by putting all of WebKit2.framework in the /System/Library/PrivateFrameworks, rather than /System/Library/Frameworks.
Comment 5 WebKit Review Bot 2011-02-23 11:43:48 PST 
http://trac.webkit.org/changeset/79459 might have broken Qt Linux Release
The following tests are not passing:
fast/overflow/overflow-height-float-not-removed-crash3.html