Bug 55042 - IndexedDB: Each layout test should use a separate DB
Summary: IndexedDB: Each layout test should use a separate DB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-23 06:08 PST by Hans Wennborg
Modified: 2011-02-23 10:35 PST (History)
4 users (show)

See Also:


Attachments
Patch (49.44 KB, patch)
2011-02-23 06:10 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-02-23 06:08:00 PST
IndexedDB: Each layout test should use a separate DB
Comment 1 Hans Wennborg 2011-02-23 06:10:03 PST
Created attachment 83478 [details]
Patch
Comment 2 Hans Wennborg 2011-02-23 06:13:53 PST
This morning saw some changes that made IndexedDB tests fail, seemingly because the tests got run in parallel. If we let each test use its own database, this shouldn't be a problem.

(This was on my Linux box after http://trac.webkit.org/changeset/79424 landed, and it went away if I ran the tests with --worker-model=old-threads. It doesn't seem to affect the bots(?), but I think we should fix it anyway.)

Please review.
Comment 3 Jeremy Orlow 2011-02-23 10:07:42 PST
Comment on attachment 83478 [details]
Patch

r=me

feel free to land yourself, but cq just in case it beats you
Comment 4 Jeremy Orlow 2011-02-23 10:08:21 PST
David/Andrei: please follow this naming scheme from now on
Comment 5 WebKit Commit Bot 2011-02-23 10:33:18 PST
The commit-queue encountered the following flaky tests while processing attachment 83478 [details]:

inspector/elements/insert-node-collapsed.html bug 55058 (author: pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-02-23 10:35:11 PST
Comment on attachment 83478 [details]
Patch

Clearing flags on attachment: 83478

Committed r79458: <http://trac.webkit.org/changeset/79458>
Comment 7 WebKit Commit Bot 2011-02-23 10:35:17 PST
All reviewed patches have been landed.  Closing bug.