Bug 55029 - [Qt] tst_QWebView::setPalette(activeFG) fails
Summary: [Qt] tst_QWebView::setPalette(activeFG) fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31742
  Show dependency tree / graph
 
Reported: 2011-02-23 03:17 PST by Csaba Osztrogonác
Modified: 2011-02-24 05:44 PST (History)
3 users (show)

See Also:

Attachments
Patch to improve the auto-test. (2.20 KB, patch)
2011-02-23 09:37 PST, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-02-23 03:17:14 PST 
FAIL!  : tst_QWebView::setPalette(activeBG) 'img1 != img2' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(426)]

FAIL!  : tst_QWebView::setPalette(activeFG) 'img1 != img2' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(426)]
Comment 1 Alexis Menard (darktears) 2011-02-23 03:23:47 PST 
It's not a regression, the tests were added with the patch :).
Comment 2 Csaba Osztrogonác 2011-02-23 03:25:22 PST 
(In reply to comment #1)
> It's not a regression, the tests were added with the patch :).

OK, it's not a regression. :) But tests introduced in r79409 still fail.
Comment 3 Alexis Menard (darktears) 2011-02-23 03:29:37 PST 
But I'm on it :)
Comment 4 Csaba Osztrogonác 2011-02-23 03:30:57 PST 
(In reply to comment #3)
> But I'm on it :)

Cool, thanks. ;)
Comment 5 Alexis Menard (darktears) 2011-02-23 09:37:40 PST 
Created attachment 83491 [details]
Patch to improve the auto-test.
Comment 6 Ariya Hidayat 2011-02-23 10:45:00 PST 
Comment on attachment 83491 [details]
Patch to improve the auto-test.

LGTM. re=me.
Comment 7 WebKit Commit Bot 2011-02-23 11:03:50 PST 
Comment on attachment 83491 [details]
Patch to improve the auto-test.

Clearing flags on attachment: 83491

Committed r79463: <http://trac.webkit.org/changeset/79463>
Comment 8 WebKit Commit Bot 2011-02-23 11:03:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Andreas Kling 2011-02-24 05:44:43 PST 
Committed r79552: <http://trac.webkit.org/changeset/79552>