Bug 55014 - Per-page minimum DOMTimer interval broken for repeating timers
Summary: Per-page minimum DOMTimer interval broken for repeating timers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 54312
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-22 19:20 PST by Kenneth Russell
Modified: 2011-02-23 10:00 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.48 KB, patch)
2011-02-22 19:42 PST, Kenneth Russell 		fishd: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-02-22 19:20:59 PST 
The logic added in https://bugs.webkit.org/show_bug.cgi?id=54312 is broken for the case of repeating timers, i.e., those set via setInterval() rather than setTimeout(). The error occurs when the minimum interval is decreased and the timer's repeat interval has already been clamped to the larger value. The current code fails to decrease the repeat interval, leaving the timer running at the slower rate.
Comment 1 Kenneth Russell 2011-02-22 19:42:55 PST 
Created attachment 83433 [details]
Patch
Comment 2 Kenneth Russell 2011-02-23 10:00:29 PST 
Committed r79455: <http://trac.webkit.org/changeset/79455>