Bug 55010 – [Chromium] update bug list and SKIP one failing test as known issue

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Chromium] update bug list and SKIP one failing test as known issue

Created attachment 83419 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 83419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83419&action=review

> LayoutTests/platform/chromium/test_expectations.txt:801
> +BUGCR25375 SKIP : media/video-controls-transformed.html = FAIL

I thought chromium only skipped tests when they caused others to fail?

[Dimitri Glazkov (Google)]

Comment on attachment 83419 [details]
Patch

I agree. Can you explain why you're skipping the test?

This test fails because of http://code.google.com/p/chromium/issues/detail?id=25375 and we (chrome media stack team) do not have immediate plan to fix it right now. So, instead of executing and failing, we will disable it to prevent false information (We are aiming at 100% passing rate for layout tests). When this bug is fixed in the near future, we will enable this back.

[Dimitri Glazkov (Google)]

(In reply to comment #4)
> This test fails because of http://code.google.com/p/chromium/issues/detail?id=25375 and we (chrome media stack team) do not have immediate plan to fix it right now. So, instead of executing and failing, we will disable it to prevent false information (We are aiming at 100% passing rate for layout tests). When this bug is fixed in the near future, we will enable this back.

That's not the way we typically do it. There are quite a few tests that we're failing today simply because the test isn't written correctly -- in a platform/port-specific manner or in a way that makes it flaky.

We assume that we lose coverage and count this test as failing until we fix it.

[Dimitri Glazkov (Google)]

Comment on attachment 83419 [details]
Patch

Please unskip the test.

Then, I withdraw this code review.