Bug 55010 - [Chromium] update bug list and SKIP one failing test as known issue
Summary: [Chromium] update bug list and SKIP one failing test as known issue
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 17:17 PST by imasaki
Modified: 2011-02-24 07:34 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2011-02-22 17:18 PST, imasaki
dglazkov: review-
dglazkov: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description imasaki 2011-02-22 17:17:35 PST
[Chromium] update bug list and SKIP one failing test as known issue
Comment 1 imasaki 2011-02-22 17:18:37 PST
Created attachment 83419 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-24 03:02:29 PST
Comment on attachment 83419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83419&action=review

> LayoutTests/platform/chromium/test_expectations.txt:801
> +BUGCR25375 SKIP : media/video-controls-transformed.html = FAIL

I thought chromium only skipped tests when they caused others to fail?
Comment 3 Dimitri Glazkov (Google) 2011-02-24 06:29:32 PST
Comment on attachment 83419 [details]
Patch

I agree. Can you explain why you're skipping the test?
Comment 4 imasaki 2011-02-24 07:05:12 PST
This test fails because of http://code.google.com/p/chromium/issues/detail?id=25375 and we (chrome media stack team) do not have immediate plan to fix it right now. So, instead of executing and failing, we will disable it to prevent false information (We are aiming at 100% passing rate for layout tests). When this bug is fixed in the near future, we will enable this back.
Comment 5 Dimitri Glazkov (Google) 2011-02-24 07:09:00 PST
(In reply to comment #4)
> This test fails because of http://code.google.com/p/chromium/issues/detail?id=25375 and we (chrome media stack team) do not have immediate plan to fix it right now. So, instead of executing and failing, we will disable it to prevent false information (We are aiming at 100% passing rate for layout tests). When this bug is fixed in the near future, we will enable this back.

That's not the way we typically do it. There are quite a few tests that we're failing today simply because the test isn't written correctly -- in a platform/port-specific manner or in a way that makes it flaky.

We assume that we lose coverage and count this test as failing until we fix it.
Comment 6 Dimitri Glazkov (Google) 2011-02-24 07:09:15 PST
Comment on attachment 83419 [details]
Patch

Please unskip the test.
Comment 7 imasaki 2011-02-24 07:34:03 PST
Then, I withdraw this code review.