rebaseline-chromium-webkit-tests can't handle GPU variants
Created attachment 83401 [details] Patch
Okay, I think this patch works, although it probably needs more testing (and unit tests) before it lands.
Okay, I'm going to land this as-is for now (assuming it gets reviewed) and file a separate bug to be able to handle the "GPU" modifier correctly so we don't need the -g flag.
Comment on attachment 83401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83401&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:148 > + def test_platform_names(self): Might be nice if the the GPU-specific behavior was done via a mixin so that there wouldn't be quite so much repetition, though that's beyond the scope of this patch.
(In reply to comment #4) > (From update of attachment 83401 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83401&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:148 > > + def test_platform_names(self): > > Might be nice if the the GPU-specific behavior was done via a mixin so that there wouldn't be quite so much repetition, though that's beyond the scope of this patch. Yeah, there's a bug filed for that already ( bug 48103) and I have a patch waiting in the wings. It'll show up next week some time.
Committed r79636: <http://trac.webkit.org/changeset/79636>