Bug 55002 - rebaseline-chromium-webkit-tests can't handle GPU variants at all
: rebaseline-chromium-webkit-tests can't handle GPU variants at all
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To: Dirk Pranke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-22 14:58 PST by Dirk Pranke
Modified: 2011-02-24 15:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.33 KB, patch)
2011-02-22 15:17 PST, Dirk Pranke
mihaip: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-22 14:58:23 PST
rebaseline-chromium-webkit-tests can't handle GPU variants
Comment 1 Dirk Pranke 2011-02-22 15:17:35 PST
Created attachment 83401 [details]
Patch
Comment 2 Dirk Pranke 2011-02-22 15:18:37 PST
Okay, I think this patch works, although it probably needs more testing (and unit tests) before it lands.
Comment 3 Dirk Pranke 2011-02-24 15:34:26 PST
Okay, I'm going to land this as-is for now (assuming it gets reviewed) and file a separate bug to be able to handle the "GPU" modifier correctly so we don't need the -g flag.
Comment 4 Mihai Parparita 2011-02-24 15:39:23 PST
Comment on attachment 83401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83401&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:148
> +    def test_platform_names(self):

Might be nice if the the GPU-specific behavior was done via a mixin so that there wouldn't be quite so much repetition, though that's beyond the scope of this patch.
Comment 5 Dirk Pranke 2011-02-24 15:45:19 PST
(In reply to comment #4)
> (From update of attachment 83401 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83401&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:148
> > +    def test_platform_names(self):
> 
> Might be nice if the the GPU-specific behavior was done via a mixin so that there wouldn't be quite so much repetition, though that's beyond the scope of this patch.

Yeah, there's a bug filed for that already ( bug 48103) and I have a patch waiting in the wings. It'll show up next week some time.
Comment 6 Dirk Pranke 2011-02-24 15:50:19 PST
Committed r79636: <http://trac.webkit.org/changeset/79636>