Bug 54999 - Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
Summary: Manage MarkedBlocks in a linked list instead of a vector, so arbitrary remova...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on: 55012
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-22 14:13 PST by Geoffrey Garen
Modified: 2011-02-23 12:25 PST (History)
2 users (show)

See Also:

Attachments
Patch (20.10 KB, patch)
2011-02-22 14:19 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (14.42 KB, patch)
2011-02-23 11:35 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (17.54 KB, patch)
2011-02-23 11:43 PST, Geoffrey Garen 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-02-22 14:13:27 PST 
Managed MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
Comment 1 Geoffrey Garen 2011-02-22 14:19:59 PST 
Created attachment 83389 [details]
Patch
Comment 2 Oliver Hunt 2011-02-22 15:00:28 PST 
Comment on attachment 83389 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2011-02-22 15:23:49 PST 
Committed r79367: <http://trac.webkit.org/changeset/79367>
Comment 4 Ryosuke Niwa 2011-02-22 19:13:19 PST 
This patch caused all tests to crash on Snow Leopard:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r79366%20(25764)/
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r79367%20(25765)/results.html

I'm rolling this patch per olliej's suggestion.
Comment 5 Simon Fraser (smfr) 2011-02-22 21:33:44 PST 
Reopening, since it was rolled out.
Comment 6 Geoffrey Garen 2011-02-23 11:35:05 PST 
Created attachment 83513 [details]
Patch
Comment 7 Darin Adler 2011-02-23 11:38:49 PST 
Comment on attachment 83513 [details]
Patch

This patch does not include the DoublyLinkedList.h header, but includes many references to it!
Comment 8 Geoffrey Garen 2011-02-23 11:43:07 PST 
Created attachment 83516 [details]
Patch
Comment 9 Darin Adler 2011-02-23 11:46:13 PST 
Comment on attachment 83516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83516&action=review

> Source/JavaScriptCore/runtime/MarkedSpace.cpp:58
> +    MarkedBlock* next = 0;

Doesn’t seem helpful to initialize this here.
Comment 10 Geoffrey Garen 2011-02-23 12:25:24 PST 
Committed r79472: <http://trac.webkit.org/changeset/79472>