RESOLVED FIXED 54996
[Qt] [WK2] When the context menu is empty, we should still send the signal QWKPage::showContextMenu() 
https://bugs.webkit.org/show_bug.cgi?id=54996
Summary [Qt] [WK2] When the context menu is empty, we should still send the signal QW...
Benjamin Poulain
Reported Tuesday, February 22, 2011 9:54:44 PM UTC
Currently, the signal QWKPage::showContextMenu() is sent only if the context menu is not empty. This can be a problem for users who want to extend the context menu because they get no notification in that case. The signal should be sent in any case, with an empty menu if necessary.
Attachments
Patch (2.64 KB, patch)
2011-02-22 14:19 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 Tuesday, February 22, 2011 10:19:17 PM UTC
Created attachment 83387 [details] Patch
Andreas Kling
Comment 2 Tuesday, February 22, 2011 10:22:55 PM UTC
Comment on attachment 83387 [details] Patch Haia!
WebKit Commit Bot
Comment 3 Wednesday, February 23, 2011 9:11:35 AM UTC
Comment on attachment 83387 [details] Patch Clearing flags on attachment: 83387 Committed r79421: <http://trac.webkit.org/changeset/79421>
WebKit Commit Bot
Comment 4 Wednesday, February 23, 2011 9:11:40 AM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.