RESOLVED FIXED 54993
[Qt] Properly propagate the palette to QWebPage from QGraphicsWebView 
https://bugs.webkit.org/show_bug.cgi?id=54993
Summary [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
Alexis Menard (darktears)
Reported 2011-02-22 13:42:25 PST
Discovered while looking at https://bugs.webkit.org/show_bug.cgi?id=31742. When we set a palette on the QGraphicsWebView we need to propagate it to the page like QWebView.
Attachments
Patch to fix the issue with auto-test (7.17 KB, patch)
2011-02-22 13:43 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch with a more robust auto-test (works in the bot). (7.48 KB, patch)
2011-02-24 05:34 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Updated version which try to make kenneth(patch) == true (6.45 KB, patch)
2011-02-24 05:42 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Wrong file taken :( sorry. (7.47 KB, patch)
2011-02-24 05:43 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-02-22 13:43:30 PST
Created attachment 83377 [details] Patch to fix the issue with auto-test
Alexis Menard (darktears)
Comment 2 2011-02-24 05:34:28 PST
Created attachment 83641 [details] Patch with a more robust auto-test (works in the bot).
WebKit Review Bot
Comment 3 2011-02-24 05:36:31 PST
Attachment 83641 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qgraphicswebview.cpp'..." exit_code: 1 Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:388: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexis Menard (darktears)
Comment 4 2011-02-24 05:42:09 PST
Created attachment 83642 [details] Updated version which try to make kenneth(patch) == true
Alexis Menard (darktears)
Comment 5 2011-02-24 05:43:01 PST
Created attachment 83643 [details] Wrong file taken :( sorry.
WebKit Review Bot
Comment 6 2011-02-24 05:45:20 PST
Attachment 83642 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qgraphicswebview.cpp'..." exit_code: 1 Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:388: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 7 2011-02-25 08:15:25 PST
Comment on attachment 83643 [details] Wrong file taken :( sorry. Clearing flags on attachment: 83643 Committed r79683: <http://trac.webkit.org/changeset/79683>
Andreas Kling
Comment 8 2011-02-25 08:15:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.