Bug 54992 - Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
Summary: Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 13:39 PST by Patrick R. Gansterer
Modified: 2011-02-23 06:05 PST (History)
1 user (show)

See Also:

Attachments
Patch (7.04 KB, patch)
2011-02-22 13:40 PST, Patrick R. Gansterer 		ap: review+
Details | Formatted Diff | Diff
Patch (11.62 KB, patch)
2011-02-23 03:41 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-02-22 13:39:51 PST 
Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
Comment 1 Patrick R. Gansterer 2011-02-22 13:40:53 PST 
Created attachment 83376 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-02-22 17:20:22 PST 
Comment on attachment 83376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83376&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:2826
> +        priv->page_settings->setStandardFontFamily(WTF::AtomicString::fromUTF8(family));

Why WTF::AtomicString?

> Source/WebKit/efl/ewk/ewk_view.cpp:2842
> +        priv->page_settings->setCursiveFontFamily(WTF::AtomicString::fromUTF8(family));

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:2858
> +        priv->page_settings->setFantasyFontFamily(WTF::AtomicString::fromUTF8(family));

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:2874
> +        priv->page_settings->setFixedFontFamily(WTF::AtomicString::fromUTF8(family));

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:2890
> +        priv->page_settings->setSerifFontFamily(WTF::AtomicString::fromUTF8(family));

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:3027
> +        priv->page_settings->setLocalStorageDatabasePath(WTF::String::fromUTF8(path));

Ditto.
Comment 3 Patrick R. Gansterer 2011-02-23 03:41:05 PST 
Created attachment 83465 [details]
Patch

(In reply to comment #2)
> > Source/WebKit/efl/ewk/ewk_view.cpp:2826
> > +        priv->page_settings->setStandardFontFamily(WTF::AtomicString::fromUTF8(family));
> 
> Why WTF::AtomicString?

Good catch.
Comment 4 WebKit Commit Bot 2011-02-23 06:05:51 PST 
Comment on attachment 83465 [details]
Patch

Clearing flags on attachment: 83465

Committed r79441: <http://trac.webkit.org/changeset/79441>
Comment 5 WebKit Commit Bot 2011-02-23 06:05:55 PST 
All reviewed patches have been landed.  Closing bug.