Bug 54991 - Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for CSS Scrollbars
Summary: Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-02-22 13:33 PST by Beth Dakin
Modified: 2011-02-22 14:29 PST (History)
4 users (show)

See Also:

Attachments
Patch (10.60 KB, patch)
2011-02-22 14:01 PST, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch that hopefully doesn't break things (10.61 KB, patch)
2011-02-22 14:12 PST, Beth Dakin 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2011-02-22 13:33:59 PST 
Right now, to determine if there are overlay scrollbars, we always consult the native theme. This is not good because that is not relevant for RenderScrollbars (CSS Scrollbars).

I have a fix.

<rdar://problem/9034318>
Comment 1 Beth Dakin 2011-02-22 14:01:32 PST 
Created attachment 83381 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-22 14:08:06 PST 
Attachment 83381 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7944405
Comment 3 Beth Dakin 2011-02-22 14:12:05 PST 
Created attachment 83384 [details]
Patch that hopefully doesn't break things
Comment 4 Beth Dakin 2011-02-22 14:29:15 PST 
Thanks Sam! Fixed with revision 79360.