Bug 54990 - [GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
Summary: [GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-02-22 12:59 PST by Martin Robinson
Modified: 2011-02-22 14:40 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2011-02-22 13:04 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-02-22 12:59:27 PST 
r79167 modified ScrollView::visibleContentsRect and we must update the forked version we use for the GTK+ port.
Comment 1 Martin Robinson 2011-02-22 13:03:20 PST 
Link to the changeset that broke the test: http://trac.webkit.org/changeset/79167
Comment 2 Martin Robinson 2011-02-22 13:04:47 PST 
Created attachment 83373 [details]
Patch
Comment 3 Xan Lopez 2011-02-22 13:06:04 PST 
Comment on attachment 83373 [details]
Patch

OK.
Comment 4 Martin Robinson 2011-02-22 13:06:48 PST 
Committed r79350: <http://trac.webkit.org/changeset/79350>
Comment 5 mitz 2011-02-22 14:20:02 PST 
Apologies for the breakage, and thanks for fixing this!
Comment 6 Martin Robinson 2011-02-22 14:40:11 PST 
(In reply to comment #5)
> Apologies for the breakage, and thanks for fixing this!

No problem! Eventually, when I have more time I'd like to figure out a way to share this code with everyone.