Bug 54987 – Crash beneath WebPageProxy::viewWillStartLiveResize when resizing window after web process crashed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Adam Roben (:aroben)]

To reproduce:

1. Kill the web process
2. Resize the window

The UI process will crash beneath WebPageProxy::viewWillStartLiveResize. viewWillStartLiveResize is dereferencing a null WebProcessProxy. Here's the backtrace:

#0  0x021a9f43 in WTF::RefPtr<WebKit::ProcessLauncher>::operator WebKit::ProcessLauncher* WTF::RefPtr<WebKit::ProcessLauncher>::* (this=0x48) at RefPtr.h:72
#1  0x021a7d12 in WebKit::WebProcessProxy::isLaunching (this=0x0) at WebProcessProxy.cpp:132
#2  0x021a841a in WebKit::WebProcessProxy::sendMessage (this=0x0, messageID={m_messageID = 655366}, arguments=@0xbfffe2d8, messageSendFlags=0) at WebProcessProxy.cpp:118
#3  0x021756a8 in WebKit::WebProcessProxy::send<Messages::WebPage::ViewWillStartLiveResize> (this=0x0, message=@0xbfffe338, destinationID=1, messageSendFlags=0) at WebProcessProxy.h:174
#4  0x021511bb in WebKit::WebPageProxy::viewWillStartLiveResize (this=0x889f200) at WebPageProxy.cpp:536
#5  0x021ca19b in -[WKView viewWillStartLiveResize] (self=0xa048560, _cmd=0x99775486) at WKView.mm:302
#6  0x98f54dc8 in -[NSView _startLiveResizeCacheOK:] ()
#7  0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#8  0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#9  0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#10 0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#11 0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#12 0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#13 0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#14 0x98f54e9f in -[NSView _startLiveResizeCacheOK:] ()
#15 0x98f54d68 in -[NSView _startLiveResize] ()
#16 0x98f54ce2 in -[NSView _startLiveResizeAsTopLevel] ()
#17 0x98f54cb7 in -[NSThemeFrame _startLiveResizeAsTopLevel] ()
#18 0x98f54c11 in -[NSWindow _startLiveResize] ()
#19 0x996880f0 in -[NSWindow(NSWindowResizing) _resizeWithEvent:] ()
#20 0x98f54a62 in -[NSTitledFrame resizeWithEvent:] ()
#21 0x98f54370 in -[NSTitledFrame mouseDown:] ()
#22 0x98f542ad in -[NSThemeFrame mouseDown:] ()
#23 0x98ef07f5 in -[NSWindow sendEvent:] ()

[Adam Roben (:aroben)]

<rdar://problem/9037685>

[Beth Dakin]

Created attachment 85999 [details]
Patch

[Beth Dakin]

I also patched WebPageProxy::initializeUIClient() since I hit the crash there after fixing the live resize spots.

[Beth Dakin]

Thanks Darin! Fixed with revision 81292.