Bug 54952 - Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
Summary: Cleaning: remove a overzealous check for the pointer "files" from Chrome::set...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Enhancement
Assignee: Benjamin Poulain
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2011-02-22 06:18 PST by Benjamin Poulain
Modified: 2011-02-22 06:50 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2011-02-22 06:22 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-02-22 06:18:44 PST 
In the following code
    if (input->isFileUpload()) {
        FileList* files = input->files();
        unsigned listSize = files->length();
        if (files && listSize > 1) {

The pointer "files" always exists if isFileUpload(). Moreover, the check is done after deferencing the pointer anyway.

Fix that :)
Comment 1 Benjamin Poulain 2011-02-22 06:22:19 PST 
Created attachment 83305 [details]
Patch
Comment 2 WebKit Commit Bot 2011-02-22 06:50:07 PST 
Comment on attachment 83305 [details]
Patch

Clearing flags on attachment: 83305

Committed r79317: <http://trac.webkit.org/changeset/79317>
Comment 3 WebKit Commit Bot 2011-02-22 06:50:12 PST 
All reviewed patches have been landed.  Closing bug.