Bug 54951 - Web Inspector: Timeline agent should have same lifetime as InspectorAgent
Summary: Web Inspector: Timeline agent should have same lifetime as InspectorAgent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 54112
  Show dependency treegraph
 
Reported: 2011-02-22 06:07 PST by Yury Semikhatsky
Modified: 2011-02-22 07:33 PST (History)
10 users (show)

See Also:


Attachments
Patch (23.65 KB, patch)
2011-02-22 06:11 PST, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
Patch that I'm going to land (22.15 KB, application/octet-stream)
2011-02-22 07:23 PST, Yury Semikhatsky
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-02-22 06:07:44 PST
Web Inspector: Timeline agent should have same lifetime as InspectorAgent
Comment 1 Yury Semikhatsky 2011-02-22 06:11:28 PST
Created attachment 83304 [details]
Patch
Comment 2 Pavel Feldman 2011-02-22 06:28:43 PST
Comment on attachment 83304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83304&action=review

> LayoutTests/inspector/timeline/timeline-network-resource.html:21
> +    TimelineAgent.startTimelineProfiler(step1);

TimelineAgent.start()

> LayoutTests/inspector/timeline/timeline-network-resource.html:31
> +        TimelineAgent.stopTimelineProfiler(step3);

.stop()

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:96
> +/*

Comment?
Comment 3 Yury Semikhatsky 2011-02-22 07:23:55 PST
Created attachment 83310 [details]
Patch that I'm going to land

All comments were addressed.
Comment 4 Yury Semikhatsky 2011-02-22 07:33:09 PST
Committed r79323: <http://trac.webkit.org/changeset/79323>