Bug 54947 – Web Inspector: [REGRESSION] navigation does not work when inspector is opened

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Navigation hangs when inspector is opened.

[Pavel Podivilov]

Created attachment 83300 [details]
Patch.

[Pavel Feldman]

Comment on attachment 83300 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=83300&action=review

> Source/WebCore/inspector/InspectorState.cpp:50
>      if (!m_properties)

else? (otherwise properties from the old instance will stay).

[Pavel Podivilov]

Committed r79319: <http://trac.webkit.org/changeset/79319>

[Csaba Osztrogonác]

(In reply to comment #3)
> Committed r79319: <http://trac.webkit.org/changeset/79319>

It broke ~90 tests on Qt bot. :( Have you got any idea why?

[Pavel Feldman]

(In reply to comment #4)
> (In reply to comment #3)
> > Committed r79319: <http://trac.webkit.org/changeset/79319>
> 
> It broke ~90 tests on Qt bot. :( Have you got any idea why?

It does not seem to change anything wrt Qt. I'll investigate a bit more.

[Pavel Feldman]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Committed r79319: <http://trac.webkit.org/changeset/79319>
> > 
> > It broke ~90 tests on Qt bot. :( Have you got any idea why?
> 
> It does not seem to change anything wrt Qt. I'll investigate a bit more.

Need a Qt build, will do tomorrow. In the meanwhile, we can either roll out or Skipp qt. I prefer the latter since it fixes a nasty problem.

[Csaba Osztrogonác]

I tried to roll out locally, but it didn't solve the problem. And then I 
tried http://trac.webkit.org/changeset/79319 and it works for me. It seems
http://trac.webkit.org/changeset/79320 broke inspector tests somehow.

[Pavel Feldman]

(In reply to comment #7)
> I tried to roll out locally, but it didn't solve the problem. And then I 
> tried http://trac.webkit.org/changeset/79319 and it works for me. It seems
> http://trac.webkit.org/changeset/79320 broke inspector tests somehow.

Oh, ok. That would explain it. The symptoms point to missing front-end. Is it deployed?

[Csaba Osztrogonác]

Andras, it seems your patch broke the inspector tests. Could you check it, please?

[Pavel Feldman]

(In reply to comment #9)
> Andras, it seems your patch broke the inspector tests. Could you check it, please?

Front-end uses generated file:

INSPECTOR_BACKEND_STUB_QRC = inspector/front-end/InspectorBackendStub.qrc

Is this line missing in the new project file?