RESOLVED FIXED 54935
[codereviewtool] focus first visible node if no node is focused 
https://bugs.webkit.org/show_bug.cgi?id=54935
Summary [codereviewtool] focus first visible node if no node is focused
Ojan Vafai
Reported 2011-02-21 21:25:13 PST
[codereviewtool] focus first visible node if no node is focused
Attachments
Patch (3.72 KB, patch)
2011-02-21 21:27 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (3.94 KB, patch)
2011-02-22 19:41 PST, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-02-21 21:27:04 PST
Created attachment 83265 [details] Patch
Adam Barth
Comment 2 2011-02-22 00:54:16 PST
Comment on attachment 83265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83265&action=review These magic numbers seem like sadness. > Websites/bugs.webkit.org/code-review.js:1412 > + y -= 30; 30? > Websites/bugs.webkit.org/code-review.js:1415 > + reference_element = document.elementFromPoint(100, y); 100?
Ojan Vafai
Comment 3 2011-02-22 19:40:16 PST
Comment on attachment 83265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83265&action=review >> Websites/bugs.webkit.org/code-review.js:1412 >> + y -= 30; > > 30? I picked this sort of arbitrarily. I made it a bit more explicit though and expanded the comment a bit. >> Websites/bugs.webkit.org/code-review.js:1415 >> + reference_element = document.elementFromPoint(100, y); > > 100? This was just dumb. Using the center of the window down.
Ojan Vafai
Comment 4 2011-02-22 19:41:29 PST
Created attachment 83432 [details] Patch
Adam Barth
Comment 5 2011-02-22 20:52:42 PST
Comment on attachment 83432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83432&action=review Ok. "var fudge" is kind of silly. > Websites/bugs.webkit.org/code-review.js:1406 > + var fudge = 30; It seems like we should be able to compute this number from something in CSSOM
Ojan Vafai
Comment 6 2011-02-22 21:40:18 PST
Committed r79399: <http://trac.webkit.org/changeset/79399>
Note You need to log in before you can comment on or make changes to this bug.