Bug 54933 - Make Editor::selectionComputedStyle return EditingStyle
Summary: Make Editor::selectionComputedStyle return EditingStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 54932
  Show dependency tree / graph
 
Reported: 2011-02-21 20:44 PST by Ryosuke Niwa
Modified: 2011-02-22 21:35 PST (History)
6 users (show)

See Also:

Attachments
cleanup (16.62 KB, patch)
2011-02-21 20:56 PST, Ryosuke Niwa 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-02-21 20:44:48 PST 
This is a cleanup.
Comment 1 Ryosuke Niwa 2011-02-21 20:56:43 PST 
Created attachment 83262 [details]
cleanup
Comment 2 Darin Adler 2011-02-22 12:02:04 PST 
Comment on attachment 83262 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=83262&action=review

> Source/WebCore/ChangeLog:9
> +        Renamed selectionComputedStyle to selectionStartComputedStyle and changed the return type to EditingStyle.
> +        It also no longer takes a boolean shouldUseFixedFontDefaultSize.

I’m not sure this function needs the word computed in it any more. When the function returned a CSS style object, then it needed computed in its name because of how the same data structure is used for actual computed style and other style purposes. I think maybe selectionStartStyle would be a suitable name.
Comment 3 Ryosuke Niwa 2011-02-22 18:55:49 PST 
Comment on attachment 83262 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=83262&action=review

>> Source/WebCore/ChangeLog:9
>> +        It also no longer takes a boolean shouldUseFixedFontDefaultSize.
> 
> I’m not sure this function needs the word computed in it any more. When the function returned a CSS style object, then it needed computed in its name because of how the same data structure is used for actual computed style and other style purposes. I think maybe selectionStartStyle would be a suitable name.

Sounds good to me.  Will rename before landing.  Thanks for the reviews!
Comment 4 Ryosuke Niwa 2011-02-22 21:35:59 PST 
Committed r79398: <http://trac.webkit.org/changeset/79398>