Bug 54925 - nrwt: revert behavior on 10.5 to "old-threads"
Summary: nrwt: revert behavior on 10.5 to "old-threads"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-21 18:54 PST by Dirk Pranke
Modified: 2022-02-27 23:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.12 KB, patch)
2011-02-21 19:01 PST, Dirk Pranke 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-21 18:54:49 PST 
nrwt: revert behavior on 10.5 to "old-threads"
Comment 1 Dirk Pranke 2011-02-21 19:01:48 PST 
Created attachment 83255 [details]
Patch
Comment 2 Dirk Pranke 2011-02-21 19:06:38 PST 
Someone wanna rubber-stamp this partial revert of r79062 ? http://trac.webkit.org/changeset/79062 

I can't explain why we'd see increased flakiness on 10.5, since we're still only running one DRT at a time, just in a different code path. I'm curious to see if changing things back to the old method does remove the flakiness and timeouts.

10.6 should be unaffected by this patch and continue to run in parallel processes by default.
Comment 3 Kent Tamura 2011-02-21 19:18:00 PST 
Comment on attachment 83255 [details]
Patch

Though I'm not so familiar with NRWT code, it's ok to do partial revert.
Comment 4 Dirk Pranke 2011-02-21 19:31:46 PST 
Committed r79279: <http://trac.webkit.org/changeset/79279>