Bug 54924 – ImageDocument::imageChanged() confuses clang's -Woverride-virtual

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nico Weber]

ImageDocument has a method called imageChanged(). It indirectly inherits from CachedResourceClient, which has a method of the same name. From what I can tell, the method in ImageDocument is not supposed to override the superclass's method. clang's -Woverride-virtual complains:

third_party/WebKit/Source/WebCore/html/ImageDocument.h:46:10:error: 'WebCore::ImageDocument::imageChanged' hides overloaded virtual function [-Woverloaded-virtual]
    void imageChanged();
         ^
In file included from third_party/WebKit/Source/WebCore/html/ImageDocument.cpp:26:
In file included from third_party/WebKit/Source/WebCore/html/ImageDocument.h:28:
In file included from third_party/WebKit/Source/WebCore/html/HTMLDocument.h:26:
third_party/WebKit/Source/WebCore/loader/cache/CachedResourceClient.h:55:22: note: hidden overloaded virtual function 'WebCore::CachedResourceClient::imageChanged' declared here
        virtual void imageChanged(CachedImage*, const IntRect* = 0) { };
                     ^

One of the two methods should be renamed.

[Nico Weber]

Created attachment 83256 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 83256 [details]
Patch

Clearing flags on attachment: 83256

Committed r79288: <http://trac.webkit.org/changeset/79288>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.