Bug 54923 - [chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
Summary: [chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 54367
  Show dependency tree / graph
 
Reported: 2011-02-21 18:39 PST by Nico Weber
Modified: 2011-02-21 23:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2011-02-21 18:46 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-02-21 18:39:34 PST 
…because the superclass ScrollView has a show() method as well:

In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/PopupMenuChromium.cpp:33:
../platform/chromium/PopupMenuChromium.h:136:10:error: 'WebCore::PopupContainer::show' hides overloaded virtual function [-Woverloaded-virtual]
    void show(const IntRect&, FrameView*, int index);
         ^
In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/PopupMenuChromium.cpp:33:
In file included from ../platform/chromium/PopupMenuChromium.h:36:
In file included from ../platform/chromium/FramelessScrollView.h:34:
../platform/ScrollView.h:265:18: note: hidden overloaded virtual function 'WebCore::ScrollView::show' declared here
    virtual void show();
                 ^
1 error generated.
Comment 1 Nico Weber 2011-02-21 18:46:03 PST 
Created attachment 83254 [details]
Patch
Comment 2 WebKit Commit Bot 2011-02-21 23:05:45 PST 
Comment on attachment 83254 [details]
Patch

Clearing flags on attachment: 83254

Committed r79294: <http://trac.webkit.org/changeset/79294>
Comment 3 WebKit Commit Bot 2011-02-21 23:05:50 PST 
All reviewed patches have been landed.  Closing bug.