RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
Created attachment 83253 [details] Patch
clang says: In file included from third_party/WebKit/Source/WebCore/rendering/FixedTableLayout.cpp:26: third_party/WebKit/Source/WebCore/rendering/RenderTableCell.h:101:9:error: 'WebCore::RenderTableCell::baselinePosition' hides overloaded virtual function [-Woverloaded-virtual] int baselinePosition() const; ^ In file included from third_party/WebKit/Source/WebCore/rendering/FixedTableLayout.cpp:25: In file included from third_party/WebKit/Source/WebCore/rendering/RenderTable.h:29: third_party/WebKit/Source/WebCore/rendering/RenderBlock.h:63:17: note: hidden overloaded virtual function 'WebCore::RenderBlock::baselinePosition' declared here virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const;
Comment on attachment 83253 [details] Patch Clearing flags on attachment: 83253 Committed r79292: <http://trac.webkit.org/changeset/79292>
All reviewed patches have been landed. Closing bug.
The commit-queue encountered the following flaky tests while processing attachment 83253 [details]: animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com) The commit-queue is continuing to process your patch.