Bug 54914 - [chromium] ChromePluginPrintContext::begin() fails to override superclass method
Summary: [chromium] ChromePluginPrintContext::begin() fails to override superclass method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 54367
  Show dependency treegraph
 
Reported: 2011-02-21 16:01 PST by Nico Weber
Modified: 2011-02-21 18:08 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.26 KB, patch)
2011-02-21 16:04 PST, Nico Weber
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-02-21 16:01:19 PST
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebKit/chromium/src/WebFrameImpl.cpp:361:18:error: 'WebKit::ChromePluginPrintContext::begin' hides overloaded virtual function [-Woverloaded-virtual]
    virtual void begin(float width)
                 ^
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebKit/chromium/src/WebFrameImpl.cpp:291:18: note: hidden overloaded virtual function 'WebKit::ChromePrintContext::begin' declared here
    virtual void begin(float width, float height)
                 ^

The signature of the superclass method was changed in http://trac.webkit.org/changeset/71964 , but the subclass was not updated.
Comment 1 Nico Weber 2011-02-21 16:04:30 PST
Created attachment 83234 [details]
Patch
Comment 2 WebKit Commit Bot 2011-02-21 18:06:18 PST
The commit-queue encountered the following flaky tests while processing attachment 83234 [details]:

animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-02-21 18:08:29 PST
Comment on attachment 83234 [details]
Patch

Clearing flags on attachment: 83234

Committed r79276: <http://trac.webkit.org/changeset/79276>
Comment 4 WebKit Commit Bot 2011-02-21 18:08:34 PST
All reviewed patches have been landed.  Closing bug.