RESOLVED FIXED 54908
'load' and 'error' events fired for @poster 
https://bugs.webkit.org/show_bug.cgi?id=54908
Summary 'load' and 'error' events fired for @poster
Eric Carlson
Reported 2011-02-21 14:38:02 PST
The test attached to https://bugs.webkit.org/show_bug.cgi?id=54685 relies on 'load' and 'error' events being fired when a poster loads or fails to load. As per the spec a <video> element should not fire any events for poster loading or failing, WebKit does so as a side effect of using HTMLImageLoader to load the poster.
Attachments
proposed patch (3.11 KB, patch)
2011-02-22 17:15 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2011-02-22 17:15:16 PST
Created attachment 83418 [details] proposed patch
Eric Carlson
Comment 2 2011-02-22 17:36:02 PST
<rdar://problem/9039962>
Eric Seidel (no email)
Comment 3 2011-02-24 03:01:23 PST
Comment on attachment 83418 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=83418&action=review > Source/WebCore/html/HTMLImageLoader.cpp:54 > + // HTMLVideoElement uses this class to load the poster image, but it should not fire events for loading or failure. > + if (element()->hasTagName(HTMLNames::videoTag)) > + return; Should it just use a subclass of this class? dispatchLoadEvent can't be too hot, so making it virtual should be easy.
Eric Seidel (no email)
Comment 4 2011-02-24 03:01:52 PST
I'm not sure what the correct design here. I'm not sure it makes sense to bake this knowledge into HTMLImageLoader, but I also don't think it's that bad either.
Eric Carlson
Comment 5 2011-02-25 12:21:27 PST
http://trac.webkit.org/changeset/79718
Note You need to log in before you can comment on or make changes to this bug.