JavaScript calls to Layout Test Controller can not be used in layout tests for XML viewer (see https://bugs.webkit.org/show_bug.cgi?id=13807) because these XML documents should not have any style information.
Created attachment 83303 [details] Patch
Comment on attachment 83303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83303&action=review > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:620 > + setDumpPixels(false); No layoutTestController() prefix intentional? > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:496 > + WKBundleFrameRef frame = WKBundlePageGetMainFrame(m_page); Why is this chance necessary?
Comment on attachment 83303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83303&action=review >> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:620 >> + setDumpPixels(false); > > No layoutTestController() prefix intentional? Yes, QT implementation does not support dumpPixels property of layoutTestController. >> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:496 >> + WKBundleFrameRef frame = WKBundlePageGetMainFrame(m_page); > > Why is this chance necessary? It's the same change for Webkit2 port. In Webkit2 layoutTestController is created in injected bundle and the information about test url is not available, so I read it from frame.
The commit-queue encountered the following flaky tests while processing attachment 83303 [details]: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 83303 [details] Patch Clearing flags on attachment: 83303 Committed r79403: <http://trac.webkit.org/changeset/79403>
All reviewed patches have been landed. Closing bug.