Bug 54871 - [Qt][V8]REGRESSION(r79157): Fix build
Summary: [Qt][V8]REGRESSION(r79157): Fix build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P1 Blocker
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-02-21 04:44 PST by Csaba Osztrogonác
Modified: 2011-02-23 04:58 PST (History)
2 users (show)

See Also:

Attachments
propsed patch (933 bytes, patch)
2011-02-21 04:59 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-02-21 04:44:01 PST 
http://trac.webkit.org/changeset/79209 broke Qt-V8 build on Linux, because
Success is a macro from SerializedScriptValue.cpp -> config.h 
-> npruntime_internal.h -> nptypes.h ->npapi.h -> X11/xlib.h  -> X11/X.h :

Status { 
        Success, 
        InputError, 
        JSException, 
        JSFailure 
};

We should undef Success before using it. Patch is coming soon.
Comment 1 Csaba Osztrogonác 2011-02-21 04:59:33 PST 
Created attachment 83151 [details]
propsed patch

See http://trac.webkit.org/changeset/67323 for similar fix.
Comment 2 Andreas Kling 2011-02-21 05:01:21 PST 
Comment on attachment 83151 [details]
propsed patch

Sigh. r=me
Comment 3 Csaba Osztrogonác 2011-02-21 05:05:41 PST 
Landed in http://trac.webkit.org/changeset/79210
Comment 4 Alexis Menard (darktears) 2011-02-23 04:58:04 PST 
Landed in http://trac.webkit.org/changeset/79210 so we can close the bug.