RESOLVED FIXED Bug 54870
[GStreamer] GRefPtr support for GstElement
https://bugs.webkit.org/show_bug.cgi?id=54870
Summary [GStreamer] GRefPtr support for GstElement
Philippe Normand
Reported 2011-02-21 04:42:32 PST
So in some places we could use GstElement smart pointer without explicitely calling gst_object_unref.
Attachments
proposed patch (7.58 KB, patch)
2011-02-21 04:46 PST, Philippe Normand
no flags
proposed patch (7.59 KB, patch)
2011-02-21 04:53 PST, Philippe Normand
mrobinson: review-
proposed patch (7.76 KB, patch)
2011-02-23 00:48 PST, Philippe Normand
mrobinson: review+
Philippe Normand
Comment 1 2011-02-21 04:46:16 PST
Created attachment 83148 [details] proposed patch
WebKit Review Bot
Comment 2 2011-02-21 04:49:21 PST
Attachment 83148 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeListsEfl.txt', u'Sourc..." exit_code: 1 Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:20: #ifndef header guard has wrong style, please use: WTF_GRefPtrGStreamer_h [build/header_guard] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 3 2011-02-21 04:53:43 PST
Created attachment 83150 [details] proposed patch
Martin Robinson
Comment 4 2011-02-21 08:22:28 PST
Comment on attachment 83150 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=83150&action=review > Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:32 > +template <> void derefGPtr<GstElement>(GstElement* ptr) > +{ > + if (ptr) > + gst_object_unref(ptr); > +} There should also be a specialization for refGPtr even if it's currently unused with your changes. If that's not there g_object_ref will be used when you assign a GRefPtr.
Philippe Normand
Comment 5 2011-02-23 00:48:47 PST
Created attachment 83455 [details] proposed patch
Philippe Normand
Comment 6 2011-02-24 04:48:36 PST
Note You need to log in before you can comment on or make changes to this bug.