Bug 54865 - [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
Summary: [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-02-21 02:31 PST by Csaba Osztrogonác
Modified: 2011-02-23 09:07 PST (History)
5 users (show)

See Also:

Attachments
Unbreak the resizing :) (1.36 KB, patch)
2011-02-23 08:42 PST, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-02-21 02:31:34 PST 
FAIL!  : tst_QGraphicsWebView::widgetsRenderingThroughCache() Compared values are not the same
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(176)]

FAIL!  : tst_QWebElement::render() 'image3 == image4' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(1014)]

FAIL!  : tst_QWebFrame::hitTestContent() Compared values are not the same
   Actual (result.linkText()): 
   Expected (QString("link text")): link text
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2688)]
Comment 1 Alexis Menard (darktears) 2011-02-23 05:37:58 PST 
Will most probably close that one :

https://bugs.webkit.org/show_bug.cgi?id=50388
Comment 2 Alexis Menard (darktears) 2011-02-23 08:33:26 PST 
Got it. I make the patch.
Comment 3 Alexis Menard (darktears) 2011-02-23 08:42:57 PST 
Created attachment 83486 [details]
Unbreak the resizing :)
Comment 4 mitz 2011-02-23 08:47:59 PST 
Thanks for writing and testing the patch. Sorry for causing this regression.
Comment 5 Alexis Menard (darktears) 2011-02-23 08:52:33 PST 
It's alright :). No worries was quite easy to understand the problem and write the fix just by looking at your patch. Thanks for the review.
Comment 6 WebKit Commit Bot 2011-02-23 09:07:46 PST 
Comment on attachment 83486 [details]
Unbreak the resizing :)

Clearing flags on attachment: 83486

Committed r79450: <http://trac.webkit.org/changeset/79450>
Comment 7 WebKit Commit Bot 2011-02-23 09:07:51 PST 
All reviewed patches have been landed.  Closing bug.