Bug 54857 - [EFL] limit touch events when only page required touch events.
Summary: [EFL] limit touch events when only page required touch events.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-21 00:21 PST by Ryuan Choi
Modified: 2011-03-10 15:23 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.14 KB, patch)
2011-02-21 16:43 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2011-02-21 21:50 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2011-02-24 16:51 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-02-21 00:21:03 PST 
ChromeClient have an api, needsTouchEvents, which tell the platform to stop forwarding touch events to WebCore.
So, We'd better to block ewk_frame_feed_touch_event when needsTouchEvents got false.
Comment 1 Ryuan Choi 2011-02-21 16:43:20 PST 
Created attachment 83240 [details]
Patch
Comment 2 Ryuan Choi 2011-02-21 21:50:30 PST 
Created attachment 83269 [details]
Patch
Comment 3 Ryuan Choi 2011-02-21 21:52:55 PST 
(In reply to comment #2)
> Created an attachment (id=83269) [details]
> Patch

Additionally fix possible leak when just returning.
Comment 4 Eric Seidel (no email) 2011-02-24 03:13:05 PST 
Comment on attachment 83269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83269&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:98
> +        Eina_Bool needs_of_touch_events:1;

This isnt' english.
Comment 5 Ryuan Choi 2011-02-24 16:51:30 PST 
Created attachment 83749 [details]
Patch
Comment 6 Ryuan Choi 2011-02-24 16:55:41 PST 
(In reply to comment #4)
> (From update of attachment 83269 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83269&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:98
> > +        Eina_Bool needs_of_touch_events:1;
> 
> This isnt' english.

I changed variable and function name.
Comment 7 Kenneth Rohde Christiansen 2011-03-09 04:27:15 PST 
Benjamin, this one seems up your alley!
Comment 8 WebKit Commit Bot 2011-03-10 15:23:17 PST 
Comment on attachment 83749 [details]
Patch

Clearing flags on attachment: 83749

Committed r80771: <http://trac.webkit.org/changeset/80771>
Comment 9 WebKit Commit Bot 2011-03-10 15:23:22 PST 
All reviewed patches have been landed.  Closing bug.