Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
Summary: Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 54934
Blocks: 54179
  Show dependency tree / graph
 
Reported: 2011-02-20 23:00 PST by Roland Steiner
Modified: 2012-04-21 17:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (21.29 KB, patch)
2011-02-20 23:11 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
patch - including moved files (70.28 KB, patch)
2011-02-20 23:14 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
patch, from SVN checkout (70.20 KB, patch)
2011-02-21 22:41 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
patch, SVN, fixes (69.27 KB, patch)
2011-02-22 01:33 PST, Roland Steiner 		tkent: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-02-20 23:00:36 PST 
Move the source files TextControlInnerElements.cpp/.h containing shadow DOM code for <input> elements from WebCore/rendering to WebCore/html/shadow as a first step in the larger refactoring of moving <input> to use the new shadow DOM approach.

(cf. https://bugs.webkit.org/show_bug.cgi?id=54179 et al)
Comment 1 Roland Steiner 2011-02-20 23:11:37 PST 
Created attachment 83132 [details]
Patch
Comment 2 Roland Steiner 2011-02-20 23:14:10 PST 
Created attachment 83133 [details]
patch - including moved files

Iiiinteresting - webkit-patch seems to have troubles with renamed/moved files. Uploading the full patch manually.
Comment 3 WebKit Review Bot 2011-02-20 23:15:48 PST 
Attachment 83132 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7939695
Comment 4 Early Warning System Bot 2011-02-20 23:23:55 PST 
Attachment 83132 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7940593
Comment 5 Kent Tamura 2011-02-21 00:08:24 PST 
Comment on attachment 83133 [details]
patch - including moved files

View in context: https://bugs.webkit.org/attachment.cgi?id=83133&action=review

The patch will lose svn revision history.
Please make a patch in svn checkout.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22479
> +				14C0BC651312432C0030E8AB /* TextControlInnerElements.h in Headers */,

The file list should be sorted.
It's ok to run sort-Xcode-project-file after you commit this patch.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25168
> +				14C0BC641312432C0030E8AB /* TextControlInnerElements.cpp in Sources */,

ditto.
Comment 6 Roland Steiner 2011-02-21 00:53:48 PST 
Note: Except for moving I left the file and class names as-is, in order to minimize changes. However, I wonder if 'InputInnerElements' (or some such) wouldn't be a nice'n'shorter name.
Comment 7 Roland Steiner 2011-02-21 22:41:55 PST 
Created attachment 83274 [details]
patch, from SVN checkout
Comment 8 Kent Tamura 2011-02-21 22:53:41 PST 
Comment on attachment 83274 [details]
patch, from SVN checkout

>Index: Source/WebCore/html/shadow/TextControlInnerElements.cpp
>===================================================================
>--- Source/WebCore/html/shadow/TextControlInnerElements.cpp	(revision 79274)	(from Source/WebCore/rendering/TextControlInnerElements.cpp:79274)
>+++ Source/WebCore/html/shadow/TextControlInnerElements.cpp	(working copy)
>@@ -0,0 +1,535 @@

Did you run "svn mv"?
The patch seems still wrong. If you operate correctly, this should be a diff from rendering/TextControlInnerElements.cpp to shadow/TextControlInnerElements.cpp.
Comment 9 Build Bot 2011-02-21 23:03:23 PST 
Attachment 83274 [details] did not build on win:
Build output: http://queues.webkit.org/results/7948033
Comment 10 Kent Tamura 2011-02-22 01:25:38 PST 
(In reply to comment #8)
> (From update of attachment 83274 [details])
> >Index: Source/WebCore/html/shadow/TextControlInnerElements.cpp
> >===================================================================
> >--- Source/WebCore/html/shadow/TextControlInnerElements.cpp	(revision 79274)	(from Source/WebCore/rendering/TextControlInnerElements.cpp:79274)
> >+++ Source/WebCore/html/shadow/TextControlInnerElements.cpp	(working copy)
> >@@ -0,0 +1,535 @@
> 
> Did you run "svn mv"?
> The patch seems still wrong. If you operate correctly, this should be a diff from rendering/TextControlInnerElements.cpp to shadow/TextControlInnerElements.cpp.

I'm sorry, I was wrong.  This block contains "(from Source/WebCore/rendering/TextControlInnerElements.cpp)".  So it's ok.

Anyway, this patch has a problem on WebCore.vcproj.
Comment 11 Roland Steiner 2011-02-22 01:33:23 PST 
Created attachment 83284 [details]
patch, SVN, fixes

Fixed Win. Also removed headers again from WebCore.pro to see if that pacifies the Qt buildbot (but interestingly it didn't seem fazed with the manual patch...)
Comment 12 Kent Tamura 2011-02-22 01:45:38 PST 
Comment on attachment 83284 [details]
patch, SVN, fixes

ok
Comment 13 Roland Steiner 2011-03-01 00:49:11 PST 
Committed r79978: <http://trac.webkit.org/changeset/79978>
Comment 14 Ryosuke Niwa 2012-04-21 17:58:04 PDT 
Comment on attachment 83284 [details]
patch, SVN, fixes

Clearing cq?