RESOLVED FIXED 54844
[codereviewtool] make escape hide the preview form 
https://bugs.webkit.org/show_bug.cgi?id=54844
Summary [codereviewtool] make escape hide the preview form
Ojan Vafai
Reported 2011-02-20 19:57:27 PST
[codereviewtool] make escape hide the preview form
Attachments
Patch (1.94 KB, patch)
2011-02-20 20:02 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (2.27 KB, patch)
2011-02-20 20:13 PST, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-02-20 20:02:55 PST
Created attachment 83121 [details] Patch
Ojan Vafai
Comment 2 2011-02-20 20:13:40 PST
Created attachment 83124 [details] Patch
Adam Barth
Comment 3 2011-02-20 20:54:21 PST
Comment on attachment 83124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83124&action=review > Websites/bugs.webkit.org/code-review.js:1087 > + var escape_key_code = 27; Don't we already have a constant for this? We should share.
Ojan Vafai
Comment 4 2011-02-20 21:44:34 PST
Committed r79180: <http://trac.webkit.org/changeset/79180>
Note You need to log in before you can comment on or make changes to this bug.