Bug 54833 - Remove pthread dependency of GCController
Summary: Remove pthread dependency of GCController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-20 13:39 PST by Patrick R. Gansterer
Modified: 2011-04-17 18:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2011-02-20 13:40 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2011-02-22 12:30 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2011-02-22 12:42 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-02-20 13:39:19 PST 
Remove pthread dependency of GCController
Comment 1 Patrick R. Gansterer 2011-02-20 13:40:53 PST 
Created attachment 83102 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-02-20 17:18:49 PST 
The patch looks fine to me, but the code as a whole doesn't. Shouldn't we call pthread_detach() in immediate return case?

CC'ing the author of this code in case I'm somehow confused.
Comment 3 Geoffrey Garen 2011-02-21 12:16:22 PST 
(In reply to comment #2)
> Shouldn't we call pthread_detach() in immediate return case?

Yes. This is a bug.
Comment 4 Patrick R. Gansterer 2011-02-21 12:18:46 PST 
Comment on attachment 83102 [details]
Patch

(In reply to comment #3)
> (In reply to comment #2)
> > Shouldn't we call pthread_detach() in immediate return case?
> 
> Yes. This is a bug.

I'll create a new patch in the next days.
Comment 5 Patrick R. Gansterer 2011-02-22 12:30:11 PST 
Created attachment 83363 [details]
Patch
Comment 6 Geoffrey Garen 2011-02-22 12:35:27 PST 
Is it safe to call detachThread after calling waitForThreadCompletion?
Comment 7 Alexey Proskuryakov 2011-02-22 12:40:56 PST 
I thought that it's one or the other, not both.
Comment 8 Patrick R. Gansterer 2011-02-22 12:42:52 PST 
Created attachment 83366 [details]
Patch

AFAIK it's no problem to do both, but the cleaner way is to to only one of them
Comment 9 Eric Seidel (no email) 2011-04-10 16:28:35 PDT 
Comment on attachment 83366 [details]
Patch

Seems sane to me.
Comment 10 WebKit Commit Bot 2011-04-17 16:08:36 PDT 
Comment on attachment 83366 [details]
Patch

Clearing flags on attachment: 83366

Committed r84113: <http://trac.webkit.org/changeset/84113>
Comment 11 WebKit Commit Bot 2011-04-17 16:08:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 WebKit Commit Bot 2011-04-17 16:20:13 PDT 
The commit-queue encountered the following flaky tests while processing attachment 83366 [details]:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2011-04-17 18:26:55 PDT 
The commit-queue encountered the following flaky tests while processing attachment 83366 [details]:

http/tests/xmlhttprequest/abort-crash.html bug 51649 (author: andersca@apple.com)
The commit-queue is continuing to process your patch.