Bug 54831 – Use DEFINE_STATIC_LOCAL for ignoreSetMutex in Structure.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Patrick R. Gansterer]

Use DEFINE_STATIC_LOCAL for ignoreSetMutex in Structure.cpp

[Patrick R. Gansterer]

Created attachment 83100 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 83100 [details]
Patch

We should really initialize the mutex from JSC::initializeThreading() to avoid race conditions. I don't know why I didn't do that when adding this code.

[Patrick R. Gansterer]

Created attachment 83135 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 83135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83135&action=review

> Source/JavaScriptCore/runtime/InitializeThreading.cpp:59
> +    Structure::initializeThreading();
>  #if ENABLE(JSC_MULTIPLE_THREADS)

I think that it would be less confusing to have the call inside the #if - at least, I was confused by seeing it in the single thread section.

[Patrick R. Gansterer]

Created attachment 83360 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 83360 [details]
Patch for landing

Rejecting attachment 83360 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
ScriptCore/runtime/Structure.cpp
Hunk #2 succeeded at 246 (offset -5 lines).
Hunk #3 succeeded at 279 with fuzz 2 (offset -9 lines).
Hunk #4 FAILED at 316.
Hunk #5 succeeded at 1185 (offset -38 lines).
1 out of 5 hunks FAILED -- saving rejects to file Source/JavaScriptCore/runtime/Structure.cpp.rej
patching file Source/JavaScriptCore/runtime/Structure.h
Hunk #1 succeeded at 136 (offset -9 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7984037

[Patrick R. Gansterer]

Created attachment 83451 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 83451 [details]
Patch for landing

Clearing flags on attachment: 83451

Committed r79435: <http://trac.webkit.org/changeset/79435>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.