Bug 54826 – [GTK] Add a setting to change the pixels per line used for scrolling

• Status: RESOLVED
• Resolution: LATER
• Component: WebKitGTK

[Alejandro G. Castro]

This will allow to change the scrolling distance per event. We have to add the setting and use it in PlatformMouseEvent and WebEventFactory.

[Alejandro G. Castro]

(In reply to comment #0)
> This will allow to change the scrolling distance per event. We have to add the setting and use it in PlatformMouseEvent and WebEventFactory.

Actually the list of files using it is:

   - WheelEventGtk.cpp
   - ScrollViewGtk.cpp
   - WebEventFactory.cpp

[Peter Hatina]

Created attachment 91675 [details]
Setting to change the pixels per line added.

The setting should be now available. I suggest to have one global object of the Settings class, as the Qt does, which gives us the ability to have application-wide settings accessible at any point. The default setting uses the value of Scrollbar::pixelsPerLineStep(), which is now free to change by void setScrollPixelCount(float count).

[Peter Hatina]

Created attachment 92395 [details]
Setting to change the pixels per line added.

I forgot to append the ChangeLogs into the patch, now it should be fine.

[Eric Seidel (no email)]

Seems like a relatively simple patch which hasn't been touched in 3 weeks.  Bueller?

[Martin Robinson]

Comment on attachment 92395 [details]
Setting to change the pixels per line added.

View in context: https://bugs.webkit.org/attachment.cgi?id=92395&action=review

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:75
> -    // FIXME: retrieve the user setting for the number of lines to scroll on each wheel event
> -    m_deltaX *= static_cast<float>(Scrollbar::pixelsPerLineStep());
> -    m_deltaY *= static_cast<float>(Scrollbar::pixelsPerLineStep());
> +    Settings* settings = Settings::globalSettings();
> +    m_deltaX *= settings->scrollPixelCount();
> +    m_deltaY *= settings->scrollPixelCount();

I think this comment actually refers to retrieving the setting from GTK+.  I do not think it is worth exposing this kind of low-level option through the API. If there is a default GTK+ value for this though, we should be sure to use it so that scrollbars move in a more native way.

Personally I do not find anything wrong with the current scrollbar behavior and feel we can probably just remove the comments and close the bug. I could be wrong though and perhaps our scrollbars could move more natively during wheel events.

[Peter Hatina]

As far as I know, Gtk does not provide a way, how to determine the default value for scrolling step. But in my opinion, the ability to set the scrolling pixel count can be useful. In comparision with other browsers, some of them allow to do this.

[Martin Robinson]

Let's skip this feature for now and determine if we need it later.