Bug 54806 - [EFL] Set of spatial navigations fixes
Summary: [EFL] Set of spatial navigations fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 18662
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-19 07:45 PST by Lukasz Slachciak
Modified: 2011-02-21 23:21 PST (History)
3 users (show)

See Also:

Attachments
Spatial navigation fixes (4.41 KB, patch)
2011-02-19 07:53 PST, Lukasz Slachciak 		tonikitoo: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Spatial navigation fixes (4.46 KB, patch)
2011-02-21 14:57 PST, Lukasz Slachciak 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Spatial navigation fixes (4.46 KB, patch)
2011-02-21 22:31 PST, Lukasz Slachciak 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukasz Slachciak 2011-02-19 07:45:39 PST 
Attached patch improves spatial navigation in EFL port:
- adds missing spatial navigation setting initialization
- some doxygen comments added
- fix for EWebLauncher which had this option disabled due to waiting for #18662 to be resolved
Comment 1 Lukasz Slachciak 2011-02-19 07:53:50 PST 
Created attachment 83074 [details]
Spatial navigation fixes
Comment 2 Antonio Gomes 2011-02-19 09:16:34 PST 
Comment on attachment 83074 [details]
Spatial navigation fixes

Guys, review docs and set cq+/- accordingly.
Comment 3 Gyuyoung Kim 2011-02-20 18:47:22 PST 
Comment on attachment 83074 [details]
Spatial navigation fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=83074&action=review

> Source/WebKit/efl/ChangeLog:6
> +        https://webkit.org/b/54806

Bug url is strange. Please change about url with https://bugs.webkit.org/show_bug.cgi?id=54806

> Source/WebKit/efl/ChangeLog:7
> +

Please add summary of this patch
Comment 4 Lukasz Slachciak 2011-02-21 14:57:52 PST 
Created attachment 83221 [details]
Spatial navigation fixes
Comment 5 Lukasz Slachciak 2011-02-21 15:01:30 PST 
Hiello Gyuyoung.
I changed url format in ChangeLog and added some additional notes
Comment 6 Gyuyoung Kim 2011-02-21 15:34:54 PST 
Comment on attachment 83221 [details]
Spatial navigation fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=83221&action=review

Please do not set "+" by yourself. Please re-upload this patch again. Then, just request commit-queue.

> Source/WebKit/efl/ChangeLog:3
> +        Reviewed by NOBODY (OOPS!).

Tonikitoo already review this patch. Please change "Reviewed by NOBODY (OOPS!)" with "Reviewed by Antonio Gomes".

> Tools/ChangeLog:3
> +        Reviewed by NOBODY (OOPS!).

Tonikitoo already review this patch. Please change "Reviewed by NOBODY (OOPS!)" with "Reviewed by Antonio Gomes".
Comment 7 Lukasz Slachciak 2011-02-21 22:31:22 PST 
Created attachment 83272 [details]
Spatial navigation fixes
Comment 8 Lukasz Slachciak 2011-02-21 22:33:20 PST 
Hello Gyuyoung.
I added reviewer and resubmitted patch.
Comment 9 WebKit Commit Bot 2011-02-21 23:21:24 PST 
Comment on attachment 83272 [details]
Spatial navigation fixes

Clearing flags on attachment: 83272

Committed r79295: <http://trac.webkit.org/changeset/79295>
Comment 10 WebKit Commit Bot 2011-02-21 23:21:29 PST 
All reviewed patches have been landed.  Closing bug.