Bug 54771 – WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jer Noble]

Videos played in a media document don't display video (just audio) under WebKit2.

[Jer Noble]

rdar://problem/8492085

[Jer Noble]

Created attachment 83007 [details]
Patch

[Sam Weinig]

Comment on attachment 83007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533
>      // Also don't claim to support accelerated rendering when in the media document, as we will then render 
>      // via QTMovieView which is already accelerated.
> -    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument();
> +    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil;

The comment here seems incorrect now.

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 83007 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review
> 
> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533
> >      // Also don't claim to support accelerated rendering when in the media document, as we will then render 
> >      // via QTMovieView which is already accelerated.
> > -    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument();
> > +    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil;
> 
> The comment here seems incorrect now.

I'll delete it.  Thanks!

[Jer Noble]

Committed r79259: <http://trac.webkit.org/changeset/79259>