Bug 54771 - WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
Summary: WebKit2: Media document videos play only sound, no video (affects trailers.ap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P1 Normal
Assignee: Jer Noble
URL: http://jhepple.com/SampleMovies/AVI_t...
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-02-18 14:02 PST by Jer Noble
Modified: 2011-02-21 15:51 PST (History)
0 users

See Also:

Attachments
Patch (3.07 KB, patch)
2011-02-18 14:21 PST, Jer Noble 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-02-18 14:02:25 PST 
Videos played in a media document don't display video (just audio) under WebKit2.
Comment 1 Jer Noble 2011-02-18 14:02:48 PST 
rdar://problem/8492085
Comment 2 Jer Noble 2011-02-18 14:21:41 PST 
Created attachment 83007 [details]
Patch
Comment 3 Sam Weinig 2011-02-18 19:29:00 PST 
Comment on attachment 83007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533
>      // Also don't claim to support accelerated rendering when in the media document, as we will then render 
>      // via QTMovieView which is already accelerated.
> -    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument();
> +    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil;

The comment here seems incorrect now.
Comment 4 Jer Noble 2011-02-18 21:29:35 PST 
(In reply to comment #3)
> (From update of attachment 83007 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review
> 
> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533
> >      // Also don't claim to support accelerated rendering when in the media document, as we will then render 
> >      // via QTMovieView which is already accelerated.
> > -    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument();
> > +    return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil;
> 
> The comment here seems incorrect now.

I'll delete it.  Thanks!
Comment 5 Jer Noble 2011-02-21 15:51:43 PST 
Committed r79259: <http://trac.webkit.org/changeset/79259>