54767 – Use hashing instead of linear search in the conservative pointer test

Bug 54767 - Use hashing instead of linear search in the conservative pointer test

Summary: Use hashing instead of linear search in the conservative pointer test

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Other OS X 10.5

Importance:	P2 Normal
Assignee:	Geoffrey Garen

URL:
Keywords:

Depends on:	54775
Blocks:
	Show dependency tree / graph

Reported:	2011-02-18 13:05 PST by Geoffrey Garen
Modified:	2011-02-18 19:43 PST (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (1.62 KB, patch) 2011-02-18 13:07 PST, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (2.77 KB, patch) 2011-02-18 16:49 PST, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (3.20 KB, patch) 2011-02-18 17:06 PST, Geoffrey Garen	sam: review+	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Geoffrey Garen 2011-02-18 13:05:59 PST

Use hashing instead of linear search in the conservative pointer test

Comment 1 Geoffrey Garen 2011-02-18 13:07:17 PST

Created attachment 83000 [details]
Patch

Comment 2 Geoffrey Garen 2011-02-18 13:10:19 PST

Committed r79022: <http://trac.webkit.org/changeset/79022>

Comment 3 Csaba Osztrogonác 2011-02-18 14:27:13 PST

It seems this patch broke many tests on the Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r79022%20%2828536%29/results.html

Could you check it please?

Comment 4 Csaba Osztrogonác 2011-02-18 15:11:40 PST

It was rolled out (http://trac.webkit.org/changeset/79037), 
because it broke many bots:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r79022%20%2825556%29/results.html (crashes)

http://build.webkit.org/results/Qt%20Linux%20Release/r79034%20(28539) (crashes and fails)

Comment 5 Geoffrey Garen 2011-02-18 16:49:47 PST

Created attachment 83034 [details]
Patch

Comment 6 Geoffrey Garen 2011-02-18 16:50:25 PST

The bug was a typo: always removing the last block from the set, instead of the block being freed.

Comment 7 Geoffrey Garen 2011-02-18 17:06:40 PST

Created attachment 83038 [details]
Patch

Comment 8 Geoffrey Garen 2011-02-18 19:43:31 PST

Committed r79079: <http://trac.webkit.org/changeset/79079>