WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
54767
Use hashing instead of linear search in the conservative pointer test
https://bugs.webkit.org/show_bug.cgi?id=54767
Summary
Use hashing instead of linear search in the conservative pointer test
Geoffrey Garen
Reported
2011-02-18 13:05:59 PST
Use hashing instead of linear search in the conservative pointer test
Attachments
Patch
(1.62 KB, patch)
2011-02-18 13:07 PST
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
Patch
(2.77 KB, patch)
2011-02-18 16:49 PST
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
Patch
(3.20 KB, patch)
2011-02-18 17:06 PST
,
Geoffrey Garen
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2011-02-18 13:07:17 PST
Created
attachment 83000
[details]
Patch
Geoffrey Garen
Comment 2
2011-02-18 13:10:19 PST
Committed
r79022
: <
http://trac.webkit.org/changeset/79022
>
Csaba Osztrogonác
Comment 3
2011-02-18 14:27:13 PST
It seems this patch broke many tests on the Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r79022%20%2828536%29/results.html
Could you check it please?
Csaba Osztrogonác
Comment 4
2011-02-18 15:11:40 PST
It was rolled out (
http://trac.webkit.org/changeset/79037
), because it broke many bots:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r79022%20%2825556%29/results.html
(crashes)
http://build.webkit.org/results/Qt%20Linux%20Release/r79034%20(28539
) (crashes and fails)
Geoffrey Garen
Comment 5
2011-02-18 16:49:47 PST
Created
attachment 83034
[details]
Patch
Geoffrey Garen
Comment 6
2011-02-18 16:50:25 PST
The bug was a typo: always removing the last block from the set, instead of the block being freed.
Geoffrey Garen
Comment 7
2011-02-18 17:06:40 PST
Created
attachment 83038
[details]
Patch
Geoffrey Garen
Comment 8
2011-02-18 19:43:31 PST
Committed
r79079
: <
http://trac.webkit.org/changeset/79079
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug