Bug 54743 - Minimal build broken
Summary: Minimal build broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-18 06:46 PST by Philippe Normand
Modified: 2011-02-22 21:22 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (2.59 KB, patch)
2011-02-18 06:48 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-02-18 06:46:22 PST 
Final link complains about missing symbols:

InspectorController::setInspectorExtensionAPI
InspectorController::dispatchMessageFromFrontend

In the InspectorController.cpp they are ifdef'd ENABLE(JAVASCRIPT_DEBUGGER) whereas they are not conditionally defined in the header file.

See patch :)
Comment 1 Philippe Normand 2011-02-18 06:48:14 PST 
Created attachment 82954 [details]
proposed patch
Comment 2 Oleg Romashin (:romaxa) 2011-02-22 16:03:15 PST 
Works, good, can anyone push this patch?
Comment 3 WebKit Commit Bot 2011-02-22 21:22:38 PST 
Comment on attachment 82954 [details]
proposed patch

Clearing flags on attachment: 82954

Committed r79394: <http://trac.webkit.org/changeset/79394>
Comment 4 WebKit Commit Bot 2011-02-22 21:22:43 PST 
All reviewed patches have been landed.  Closing bug.