Bug 54742 - [Qt] The localized vendor name for Qt SIS packages should be "Nokia"
Summary: [Qt] The localized vendor name for Qt SIS packages should be "Nokia"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Normal
Assignee: Ademar Reis
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-02-18 06:21 PST by Ademar Reis
Modified: 2011-02-21 06:13 PST (History)
2 users (show)

See Also:

Attachments
patch (1.78 KB, patch)
2011-02-18 06:24 PST, Ademar Reis 		no flags Details | Formatted Diff | Diff
patch with better changelog (1.99 KB, patch)
2011-02-18 06:30 PST, Ademar Reis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ademar Reis 2011-02-18 06:21:45 PST 
From a commit in the Qt repository:

"""
    The previously used name "Nokia, Qt" was not usable for Nokia
    Content Signing, which only allows "Nokia" as the visible vendor
    name. The unique vendor ID remains as "Nokia, Qt"
"""

This change was applied to Qt sources (qt/src/3rdparty/webkit, 4.7 branch), so we should do the same on QtWebKit.

Patch is on the way.
Comment 1 Ademar Reis 2011-02-18 06:24:12 PST 
Created attachment 82950 [details]
patch
Comment 2 Ademar Reis 2011-02-18 06:30:29 PST 
Created attachment 82952 [details]
patch with better changelog
Comment 3 WebKit Commit Bot 2011-02-18 19:38:42 PST 
Comment on attachment 82952 [details]
patch with better changelog

Clearing flags on attachment: 82952

Committed r79077: <http://trac.webkit.org/changeset/79077>
Comment 4 WebKit Commit Bot 2011-02-18 19:38:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ademar Reis 2011-02-21 05:48:57 PST 
Revision r79077 cherry-picked into qtwebkit-2.0 with commit b564ef9 <http://gitorious.org/webkit/qtwebkit/commit/b564ef9>
Comment 6 Ademar Reis 2011-02-21 05:50:56 PST 
Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba>
Comment 7 Suresh Voruganti 2011-02-21 06:09:53 PST 
(In reply to comment #6)
> Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba>

Do we need to cherry pick the fix to Qtwebkit 2.1.x also?
Comment 8 Ademar Reis 2011-02-21 06:13:07 PST 
(In reply to comment #7)
> (In reply to comment #6)
> > Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba>
> 
> Do we need to cherry pick the fix to Qtwebkit 2.1.x also?

This is automatic: 2.1.x is constantly merged with 2.1 to make sure we have no regressions.