Bug 54741 – [Qt] Regression : on www.gmail.com a strange rendering issue appears on the menu bar due to flash.

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Alexis Menard (darktears)]

The patch ( http://trac.webkit.org/changeset/67516 ) introduce the "regression". Actually to me it was not working before but the bug fixed by the patch reveals it. On GMail.com there is a flash plugin loaded to play the sound of the chat.

<embed id="flash_object" src="im/chatsound.swf" style="position:absolute;top:0px;left:0px;height:0px;width:0px;" quality="high" pluginspage="http://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash">

The height and the width are 0. There is nothing to render and QX11EmbedContainer and all the X plumbing we have seem to be very confuse about that.


My patch propose to not show the plugins with a height or a width null. Anyway even before 67516 you could see flicker on the menu bar and now with the patch it's totally clean. 


I've tested that the sound is still played :).

[Alexis Menard (darktears)]

Created attachment 82945 [details]
Patch to fix the plugin rendering issues.

Please give me feedback on that one and add to commit queue.

[Alexis Menard (darktears)]

*** Bug 52658 has been marked as a duplicate of this bug. ***

[Andreas Kling]

Comment on attachment 82945 [details]
Patch to fix the plugin rendering issues.

View in context: https://bugs.webkit.org/attachment.cgi?id=82945&action=review

r=me, but my inner kenneth has some complaints :)

> Source/WebCore/ChangeLog:5
> +        [Qt] Regression : on www.gmail.com a strange rendering issue appears on the

If you know which commit caused the regression, we typically put something like "REGRESSION(r12345): Bla bla bla."

> Source/WebCore/ChangeLog:6
> +         menu bar due to flash.

<kenneth>Extra space before "menu"!</kenneth>

> Source/WebCore/ChangeLog:10
> +        Only show plugins with a valid size. We then avoid X in the game if there is
> +        nothing to see anyway.

s/X/involving X11/ for clarity.

> Source/WebCore/plugins/qt/PluginViewQt.cpp:144
> +    // The plugin had a zero width or height before but was resized, we need to show it again

<kenneth>Needs period at end of sentence.</kenneth>

> Source/WebCore/plugins/qt/PluginViewQt.cpp:949
> +    // If the width and the height are not zero we show the pluginView

<kenneth>Needs period at end of sentence.</kenneth>
Also, s/pluginView/PluginView/

[Alexis Menard (darktears)]

Created attachment 82947 [details]
Updated version which try to make kenneth(patch) == true

[WebKit Commit Bot]

Comment on attachment 82947 [details]
Updated version which try to make kenneth(patch) == true

Clearing flags on attachment: 82947

Committed r79074: <http://trac.webkit.org/changeset/79074>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.