Bug 54726 - use actual browser focus in the code review tool
Summary: use actual browser focus in the code review tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 23:32 PST by Ojan Vafai
Modified: 2011-02-20 18:29 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2011-02-17 23:34 PST, Ojan Vafai 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-02-17 23:32:27 PST 
use actual browser focus in the code review tool
Comment 1 Ojan Vafai 2011-02-17 23:34:20 PST 
Created attachment 82927 [details]
Patch
Comment 2 Adam Barth 2011-02-18 11:37:54 PST 
Comment on attachment 82927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82927&action=review

> Websites/bugs.webkit.org/code-review.js:1342
> +    // Give a tabindex so the element can receive actual browser focus.
> +    // -1 makes the element focusable without actually putting in in the tab order.
> +    node.attr('tabindex', -1);

Crazy!
Comment 3 Ojan Vafai 2011-02-20 18:29:32 PST 
Committed r79163: <http://trac.webkit.org/changeset/79163>