Bug 54712 - Make editing/selection/extend-selection tests more human readable and hand-runnable
Summary: Make editing/selection/extend-selection tests more human readable and hand-ru...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Benjamin (Ben) Kalman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 20:52 PST by Benjamin (Ben) Kalman
Modified: 2011-02-20 17:35 PST (History)
2 users (show)

See Also:


Attachments
Patch (43.33 KB, patch)
2011-02-17 20:56 PST, Benjamin (Ben) Kalman
no flags Details | Formatted Diff | Diff
Patch for landing (43.38 KB, patch)
2011-02-20 17:01 PST, Benjamin (Ben) Kalman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin (Ben) Kalman 2011-02-17 20:52:09 PST
Make editing/selection/extend-selection tests more human readable and hand-runnable
Comment 1 Benjamin (Ben) Kalman 2011-02-17 20:56:45 PST
Created attachment 82911 [details]
Patch
Comment 2 Ryosuke Niwa 2011-02-18 04:12:04 PST
Comment on attachment 82911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82911&action=review

> LayoutTests/editing/selection/resources/extend-selection.js:196
> +            button.onmousedown = function(event) {
> +                event.preventDefault();
> +                event.stopPropagation();
> +            };

I don't quite get why you do this.
Comment 3 Benjamin (Ben) Kalman 2011-02-20 16:45:51 PST
Comment on attachment 82911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82911&action=review

>> LayoutTests/editing/selection/resources/extend-selection.js:196
>> +            };
> 
> I don't quite get why you do this.

it's to prevent clicking the button from cancelling the selection.
i've added a small comment.
Comment 4 Benjamin (Ben) Kalman 2011-02-20 17:01:20 PST
Created attachment 83109 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-02-20 17:35:44 PST
Comment on attachment 83109 [details]
Patch for landing

Clearing flags on attachment: 83109

Committed r79160: <http://trac.webkit.org/changeset/79160>
Comment 6 WebKit Commit Bot 2011-02-20 17:35:49 PST
All reviewed patches have been landed.  Closing bug.