RESOLVED FIXED 54712
Make editing/selection/extend-selection tests more human readable and hand-runnable 
https://bugs.webkit.org/show_bug.cgi?id=54712
Summary Make editing/selection/extend-selection tests more human readable and hand-ru...
Benjamin (Ben) Kalman
Reported 2011-02-17 20:52:09 PST
Make editing/selection/extend-selection tests more human readable and hand-runnable
Attachments
Patch (43.33 KB, patch)
2011-02-17 20:56 PST, Benjamin (Ben) Kalman 		no flags
DetailsFormatted DiffDiff
Patch for landing (43.38 KB, patch)
2011-02-20 17:01 PST, Benjamin (Ben) Kalman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin (Ben) Kalman
Comment 1 2011-02-17 20:56:45 PST
Created attachment 82911 [details] Patch
Ryosuke Niwa
Comment 2 2011-02-18 04:12:04 PST
Comment on attachment 82911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82911&action=review > LayoutTests/editing/selection/resources/extend-selection.js:196 > + button.onmousedown = function(event) { > + event.preventDefault(); > + event.stopPropagation(); > + }; I don't quite get why you do this.
Benjamin (Ben) Kalman
Comment 3 2011-02-20 16:45:51 PST
Comment on attachment 82911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82911&action=review >> LayoutTests/editing/selection/resources/extend-selection.js:196 >> + }; > > I don't quite get why you do this. it's to prevent clicking the button from cancelling the selection. i've added a small comment.
Benjamin (Ben) Kalman
Comment 4 2011-02-20 17:01:20 PST
Created attachment 83109 [details] Patch for landing
WebKit Commit Bot
Comment 5 2011-02-20 17:35:44 PST
Comment on attachment 83109 [details] Patch for landing Clearing flags on attachment: 83109 Committed r79160: <http://trac.webkit.org/changeset/79160>
WebKit Commit Bot
Comment 6 2011-02-20 17:35:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.