Bug 54691 - nrwt: fix rebaselining for a generic directory
Summary: nrwt: fix rebaselining for a generic directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 54736
  Show dependency treegraph
 
Reported: 2011-02-17 14:50 PST by Dirk Pranke
Modified: 2011-02-18 14:48 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.20 KB, patch)
2011-02-17 14:51 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
take two (2.39 KB, patch)
2011-02-17 15:07 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (9.61 KB, patch)
2011-02-17 16:24 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
clarify behavior of baseline_path for chromium-mac-snowleopard, chromium-win-win7 (11.32 KB, patch)
2011-02-18 14:41 PST, Dirk Pranke
mihaip: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-17 14:50:58 PST
nrwt: fix rebaselining for a generic directory
Comment 1 Dirk Pranke 2011-02-17 14:51:45 PST
Created attachment 82865 [details]
Patch
Comment 2 Dirk Pranke 2011-02-17 15:07:19 PST
Created attachment 82867 [details]
take two
Comment 3 Dirk Pranke 2011-02-17 16:24:10 PST
Created attachment 82875 [details]
Patch
Comment 4 Dirk Pranke 2011-02-17 16:30:15 PST
Okay, this third patch is close to the "right" fix. I put "right" in quotation marks because there are at least two things wrong with using rebaseline-chromium-webkit-tests these days that keep it from being truly safe.

The first is that we don't have a full complement of stable bots on the different versions (Win 7, Vista, SL), and so we hack around this in order to get the baselines in the right place. What should happen is that if you want something to go into chromium-win, you should either rebaseline the WIN-7 version of the test, or rebaseline all of the versions of the test and rely on the deduping logic to leave a single copy.

The second is that I believe chromium-win-win7 is actually using platform/chromium-win-win7 as the baseline_path(), which is just wrong. I'm not fixing this now because I have another set of patches coming up that will fix this and continue to make the version code cleaner and more consistent across ports, and I'll fix it as part of that. We have a similar, but more debatable, issue w/ snow leopard (debatable because SL should either be using chromium-mac-snowleopard or chromium-mac depending on whether you think "lion" is a real port or not yet.
Comment 5 Dirk Pranke 2011-02-18 14:41:04 PST
Created attachment 83010 [details]
clarify behavior of baseline_path for chromium-mac-snowleopard, chromium-win-win7
Comment 6 Dirk Pranke 2011-02-18 14:48:45 PST
Committed r79035: <http://trac.webkit.org/changeset/79035>