Bug 54681 - [v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test
Summary: [v8] Change expectations for plugins/netscape-plugin-poperty-access-exception...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: anton muhin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 12:45 PST by anton muhin
Modified: 2011-04-08 01:47 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.27 KB, patch)
2011-02-17 12:54 PST, anton muhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2011-02-17 12:45:41 PST
[v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test
Comment 1 anton muhin 2011-02-17 12:49:11 PST
Guys,

sorry for shooting in the dark: I hope at least you can point out other people who can review this patch or ideally review it yourselves.

I am fixing some issues with the way v8 process exceptions and that changes the way NPPlugins report exceptions.  I hope my changes are ok---after all Safari, Chromium and FF apparently all behave differently.  But if you have any concerns, I'd be happy to here and address them.
Comment 2 anton muhin 2011-02-17 12:54:12 PST
Created attachment 82851 [details]
Patch
Comment 3 Adam Barth 2011-02-17 12:55:37 PST
Sorry, I don't know much about these tests.  It's too bad that everyone does something different...
Comment 4 anton muhin 2011-02-18 02:34:07 PST
(In reply to comment #3)
> Sorry, I don't know much about these tests.  It's too bad that everyone does something different...

With which I definitely agree.  But I strongly suspect current Chromium's expectations just capture the erroneous behaviour of current v8's exception handling.
Comment 5 Adam Barth 2011-02-18 11:40:16 PST
Comment on attachment 82851 [details]
Patch

ok.  I'm not super confident in this review, but it's probably ok.
Comment 6 anton muhin 2011-02-21 09:47:49 PST
Thanks a lot, Adam.  I'll submit when v8 with my patch gets rolled.

(In reply to comment #5)
> (From update of attachment 82851 [details])
> ok.  I'm not super confident in this review, but it's probably ok.
Comment 7 WebKit Commit Bot 2011-04-08 01:47:17 PDT
Comment on attachment 82851 [details]
Patch

Clearing flags on attachment: 82851

Committed r83269: <http://trac.webkit.org/changeset/83269>
Comment 8 WebKit Commit Bot 2011-04-08 01:47:24 PDT
All reviewed patches have been landed.  Closing bug.